perf: cache statx results in DFileInfoPrivate::attributesBySelf#325
Conversation
Introduce ensureStatxCached() to consolidate six independent statx syscalls into one. Cache the result in mutable member fields so that subsequent time-attribute queries reuse the same buffer. 在 attributesBySelf 中引入 ensureStatxCached() 方法，将 6 个时间 属性的重复 statx 系统调用合并为一次，结果缓存后各 case 直接读取。 Log: 优化 attributesBySelf 中 statx 调用，消除重复系统调用 Task: https://pms.uniontech.com/task-view-391003.html Influence: 查询 kTimeCreated/Modified/Access 等属性时，statx 从最多 6 次降为 1 次，减少不必要的系统调用开销。
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @liyigang1, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
deepin pr auto review★ 总体评分：100分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 // 当前代码已非常优秀，无需额外修改，此处仅展示保持当前实现的参考结构
bool DFileInfoPrivate::ensureStatxCached() const
{
if (statxCached)
return statxValid;
statxCached = true;
const QUrl &url = q->uri();
if (!url.isLocalFile())
return false;
unsigned mask = STATX_BASIC_STATS | STATX_BTIME;
int ret = statx(AT_FDCWD, url.path().toStdString().data(),
AT_SYMLINK_NOFOLLOW | AT_NO_AUTOMOUNT, mask, &statxBuf);
statxValid = (ret == 0);
return statxValid;
} |
liyigang1
changed the title
liyigang1
changed the title
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Johnson-zs, liyigang1 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/merge |
3 participants
Introduce ensureStatxCached() to consolidate six independent statx syscalls into one. Cache the result in mutable member fields so that subsequent time-attribute queries reuse the same buffer.
在 attributesBySelf 中引入 ensureStatxCached() 方法，将 6 个时间 属性的重复 statx 系统调用合并为一次，结果缓存后各 case 直接读取。
Log: 优化 attributesBySelf 中 statx 调用，消除重复系统调用
Task: https://pms.uniontech.com/task-view-391003.html Influence: 查询 kTimeCreated/Modified/Access 等属性时，statx 从最多 6 次降为 1 次，减少不必要的系统调用开销。