Skip to content

fix(dfm-io): drain GLib deferred callbacks after g_file_enumerate_chi… #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Johnson-zs merged 1 commit into from
Jun 24, 2026
Merged

fix(dfm-io): drain GLib deferred callbacks after g_file_enumerate_chi… #321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/dfm-io/dfm-io/denumerator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,18 @@ bool DEnumeratorPrivate::createEnumerator(const QUrl &url, QPointer<DEnumeratorP
enumLinks ? G_FILE_QUERY_INFO_NONE : G_FILE_QUERY_INFO_NOFOLLOW_SYMLINKS,
cancellable,
&gerror);

// g_file_enumerate_children internally creates and destroys temporary
// GDBusProxy instances (mount tracker proxy, daemon proxy). During proxy
// finalization, g_dbus_connection_signal_unsubscribe defers the
// user_data_free_func (weak_ref_free) to the thread-default GMainContext
// via call_destroy_notify() — a g_idle_source. Process it now while we
// are on the same thread, otherwise the GWeakRef (8 bytes from
// gdbusproxy.c:112) leaks when no GLib main loop runs on this QThread.
// See: glib2.0/gio/gdbusconnection.c:signal_subscriber_unref → call_destroy_notify
GMainContext *ctx = g_main_context_get_thread_default();
if (ctx)
g_main_context_iteration(ctx, TRUE);
if (!me) {
// Clean up the enumerator if it was created but the object is no longer valid
if (genumerator) {
Expand Down
Loading