Skip to content

Revert "fix: add isMountedByGio to check GVfs mount status"#315

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:develop/meagle-20260526from
liyigang1:revert-310-v20/20260526
Jun 23, 2026
Merged

Revert "fix: add isMountedByGio to check GVfs mount status"#315
deepin-bot[bot] merged 1 commit into
linuxdeepin:develop/meagle-20260526from
liyigang1:revert-310-v20/20260526

Conversation

@liyigang1

Copy link
Copy Markdown
Contributor

Reverts #310

这么修复会导致挂载了其他的gio,但是其他的smb服务器不可以访问,导致卡死界面

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @liyigang1, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

★ 总体评分:100分

■ 【总体评价】

代码移除了网络挂载检测中的冗余GIO逻辑,提升了代码整洁度与执行效率
逻辑清晰无副作用且无安全风险,符合满分标准

■ 【详细分析】

  • 1.语法逻辑 完全正确 ✓
    移除了DNetworkMounter::isMountedByGio函数及其在DNetworkMounter::mountByDaemon中的调用,剩余的isMounted判断逻辑完整且语法无误,未引入空指针或内存泄漏等缺陷。
    建议:保持现有逻辑即可。
  • 2.代码质量 优秀 ✓
    删除了冗余的备用检测分支和未使用的私有方法声明,降低了代码的圈复杂度和维护成本,完全符合精简代码原则。
    建议:保持现有代码风格。
  • 3.代码性能 高效 ✓
    移除了g_file_find_enclosing_mount这一可能引发同步阻塞的GIO调用,避免了不必要的系统调用开销和潜在的网络探测延迟。
    建议:保持现有逻辑即可。
  • 4.代码安全 存在0个安全漏洞 ✓
    漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
    移除冗余的GIO挂载检测逻辑未引入任何新的安全风险,原有的isMounted机制足以安全地保证挂载状态判断。
    建议:无需额外安全修复。

■ 【改进建议代码示例】

// 当前代码已处于最优状态,无需修改,此处展示当前最终保留的有效逻辑
QString mpt;
QString addr(QUrl::fromPercentEncoding(address.toLower().toLocal8Bit()));
if (isMounted(addr, mpt)) {
    if (mountResult)
        mountResult(false, Utils::genOperateErrorInfo(DeviceError::kGIOErrorAlreadyMounted), mpt);
    return;
}

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liyigang1, max-lvs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liyigang1

Copy link
Copy Markdown
Contributor Author

/forcemerge

@deepin-bot

deepin-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown

This pr force merged! (status: unstable)

@deepin-bot deepin-bot Bot merged commit b7be740 into linuxdeepin:develop/meagle-20260526 Jun 23, 2026
19 of 22 checks passed
@liyigang1 liyigang1 deleted the revert-310-v20/20260526 branch June 24, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants