fix: fix AlertToolTip parent causing drag issues#596
Merged
18202781743 merged 1 commit intolinuxdeepin:masterfrom Mar 31, 2026
Merged
fix: fix AlertToolTip parent causing drag issues#59618202781743 merged 1 commit intolinuxdeepin:masterfrom
18202781743 merged 1 commit intolinuxdeepin:masterfrom
Conversation
Fixed an issue where AlertToolTip's parent was set to Overlay.overlay when shown, which could interfere with window dragging functionality. The tooltip's children were being displayed in the overlay layer, potentially blocking mouse events on the window title bar. Now the parent is conditionally set to the target when not shown, and only to Overlay.overlay when actually visible. Log: Fixed an issue where tooltips could interfere with window dragging Influence: 1. Test that AlertToolTip displays correctly when triggered 2. Verify that window title bar remains fully draggable when tooltip is not shown 3. Check that tooltip positioning and animations work properly 4. Ensure tooltip doesn't block mouse events on underlying UI elements 5. Test tooltip behavior during window drag operations fix: 修复AlertToolTip父级设置导致窗口拖动问题 修复了AlertToolTip在显示时父级设置为Overlay.overlay导致可能干扰窗口 拖动功能的问题。工具提示的子元素在覆盖层显示,可能会阻挡窗口标题栏上 的鼠标事件。现在父级在未显示时条件性地设置为目标元素,仅在可见时设置 为Overlay.overlay。 Log: 修复了工具提示可能干扰窗口拖动的问题 Influence: 1. 测试AlertToolTip在触发时是否正确显示 2. 验证工具提示未显示时窗口标题栏是否完全可拖动 3. 检查工具提示定位和动画是否正常工作 4. 确保工具提示不会阻挡底层UI元素的鼠标事件 5. 测试窗口拖动操作期间的工具提示行为 PMS: BUG-354939
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts AlertToolTip’s parent binding so the tooltip only moves into the global overlay when visible, and otherwise remains a child of its target to avoid blocking window drag and other mouse events. Sequence diagram for AlertToolTip visibility and parent changesequenceDiagram
actor User
participant Window
participant TargetControl
participant AlertToolTip
participant OverlayOverlay
User->>TargetControl: Trigger_alert_condition
TargetControl->>AlertToolTip: set_shown(true)
AlertToolTip->>AlertToolTip: _shown = true
AlertToolTip->>OverlayOverlay: parent = Overlay.overlay
AlertToolTip->>OverlayOverlay: Render_tooltip_in_overlay
User->>Window: Drag_title_bar
Window->>Window: Drag_events_not_blocked_by_tooltip
User->>TargetControl: Condition_clears
TargetControl->>AlertToolTip: set_shown(false)
AlertToolTip->>AlertToolTip: _shown = false
AlertToolTip->>TargetControl: parent = target
AlertToolTip->>TargetControl: Tooltip_hidden_and_no_longer_in_overlay
State diagram for AlertToolTip visibility and parent bindingstateDiagram-v2
[*] --> Hidden
Hidden: parent = target
Visible: parent = Overlay.overlay
Hidden --> Visible: _shown = true
Visible --> Hidden: _shown = false
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
robertkill
approved these changes
Mar 31, 2026
BLumia
approved these changes
Mar 31, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia, robertkill The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue where AlertToolTip's parent was set to Overlay.overlay
when shown, which could interfere with window dragging functionality.
The tooltip's children were being displayed in the overlay layer,
potentially blocking mouse events on the window title bar. Now the
parent is conditionally set to the target when not shown, and only to
Overlay.overlay when actually visible.
Log: Fixed an issue where tooltips could interfere with window dragging
Influence:
not shown
fix: 修复AlertToolTip父级设置导致窗口拖动问题
修复了AlertToolTip在显示时父级设置为Overlay.overlay导致可能干扰窗口
拖动功能的问题。工具提示的子元素在覆盖层显示,可能会阻挡窗口标题栏上
的鼠标事件。现在父级在未显示时条件性地设置为目标元素,仅在可见时设置
为Overlay.overlay。
Log: 修复了工具提示可能干扰窗口拖动的问题
Influence:
PMS: BUG-354939
Summary by Sourcery
Bug Fixes: