fix(EditPanel): add z-index to AlertToolTip to prevent being blocked#595
Closed
add-uos wants to merge 1 commit intolinuxdeepin:masterfrom
Closed
fix(EditPanel): add z-index to AlertToolTip to prevent being blocked#595add-uos wants to merge 1 commit intolinuxdeepin:masterfrom
add-uos wants to merge 1 commit intolinuxdeepin:masterfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideSets a high z-order for the EditPanel AlertToolTip so it reliably appears above other UI elements, resolving a visual overlap issue. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider avoiding the hard-coded
z: 10000magic number by either defining a named constant or using a value relative to surrounding components so future layout changes are easier to reason about. - It may be safer to scope the higher
zto only whenshowAlertis true (e.g., using a Binding or state), so the tooltip doesn't unintentionally block interactions when it is hidden or not needed.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider avoiding the hard-coded `z: 10000` magic number by either defining a named constant or using a value relative to surrounding components so future layout changes are easier to reason about.
- It may be safer to scope the higher `z` to only when `showAlert` is true (e.g., using a Binding or state), so the tooltip doesn't unintentionally block interactions when it is hidden or not needed.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Add z-index property to AlertToolTip component to ensure it displays on top of other UI elements. Set z-index to 10000 to prevent the alert tooltip from being hidden behind other components. 为AlertToolTip组件添加z-index属性,确保提示框显示在其他UI元素之上。 将z-index设置为10000,防止提示框被其他组件遮挡。 Log: 修复EditPanel提示框被遮挡问题 PMS: BUG-353943 Influence: 修复后EditPanel的AlertToolTip提示框将正常显示,不会被其他UI 元素遮挡,提升用户体验。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add z-index property to AlertToolTip component to ensure it displays on top of other UI elements. Set z-index to 10000 to prevent the alert tooltip from being hidden behind other components.
为AlertToolTip组件添加z-index属性,确保提示框显示在其他UI元素之上。
将z-index设置为10000,防止提示框被其他组件遮挡。
Log: 修复EditPanel提示框被遮挡问题
PMS: BUG-353943
Influence: 修复后EditPanel的AlertToolTip提示框将正常显示,不会被其他UI 元素遮挡,提升用户体验。
Summary by Sourcery
Bug Fixes: