Feat: Add translate for cpu info.#654
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:develop/eaglefrom May 7, 2026
Merged
Feat: Add translate for cpu info.#654deepin-bot[bot] merged 1 commit intolinuxdeepin:develop/eaglefrom
deepin-bot[bot] merged 1 commit intolinuxdeepin:develop/eaglefrom
Conversation
--Add translate for cpu info. Log: add feature for cpu info show. Task: https://pms.uniontech.com/task-view-387697.html
Reviewer's GuideAdds localized translation entries for new CPU information fields emitted by DeviceGenerator across all supported languages, and refreshes line-number metadata for existing messages after source changes. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto reviewGit Diff 代码审查报告1. 总体概述这是一个针对deepin-devicemanager项目的多语言翻译文件(.ts)的更新diff。主要变化包括：
2. 语法逻辑分析2.1 代码行号变更多个文件中的代码行号有统一增加的趋势，例如：
分析：这些行号变更表明源代码文件中添加了新的代码行，导致后续代码行号后移。这是正常的开发过程，但需要确认：
2.2 新增DeviceGenerator上下文新增了DeviceGenerator上下文，包含以下翻译项： <context>
<name>DeviceGenerator</name>
<message>
<location filename="../src/GenerateDevice/DeviceGenerator.cpp" line="1269"/>
<source>Model Name</source>
<translation type="unfinished"></translation>
</message>
<!-- 其他类似条目 -->
</context>分析：这是一个新增的功能模块，用于显示CPU相关信息。翻译项包括：
3. 代码质量评估3.1 翻译完整性
建议：
3.2 翻译一致性在不同语言版本中，相同术语的翻译存在一些差异： 例如"Core(s)"的翻译：
分析：这些翻译在各自的语境中都是合理的，但建议：
3.3 代码格式所有翻译文件遵循Qt Linguist的TS文件格式，格式规范，结构清晰。 4. 性能考虑翻译文件本身不会直接影响程序性能，但以下几点值得注意：
5. 安全性评估翻译文件本身不包含可执行代码，因此不会直接引入安全风险。但需要注意：
6. 改进建议
7. 结论本次diff主要是对翻译文件的更新，包括代码行号调整和新增DeviceGenerator上下文的翻译。整体上，翻译文件格式规范，结构清晰。主要需要关注的是完成所有语言版本的翻译，确保术语一致性，以及保持翻译文件与源代码的同步。 没有发现明显的语法错误、性能问题或安全风险。建议按照上述改进建议进一步完善翻译工作。 |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- In several locales the newly added
DeviceGeneratorstrings are left withtype="unfinished"or differ in terminology from the existingDeviceCpustrings (e.g.,Core(s)), which can lead to inconsistent UI; consider aligning the translations and removing the unfinished markers where appropriate. - Since you've introduced a new
DeviceGeneratorcontext and CPU info labels, double-check that their wording matches the existing CPU-related labels (e.g., for cores and threads) so users see consistent terminology across all CPU-related views.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In several locales the newly added `DeviceGenerator` strings are left with `type="unfinished"` or differ in terminology from the existing `DeviceCpu` strings (e.g., `Core(s)`), which can lead to inconsistent UI; consider aligning the translations and removing the unfinished markers where appropriate.
- Since you've introduced a new `DeviceGenerator` context and CPU info labels, double-check that their wording matches the existing CPU-related labels (e.g., for cores and threads) so users see consistent terminology across all CPU-related views.
## Individual Comments
### Comment 1
<location path="deepin-devicemanager/translations/deepin-devicemanager_ug.ts" line_range="2371-2303" />
<code_context>
<message>
- <location filename="../src/Page/PageDriverControl.cpp" line="209"/>
+ <location filename="../src/Page/PageDriverControl.cpp" line="210"/>
<source>Previous</source>
<comment>button</comment>
<translation>Previous</translation>
</code_context>
<issue_to_address>
**issue (bug_risk):** The Uyghur translation for "Previous" is the same as "Next", which can confuse users.
Please update the Uyghur translation for this string to a word meaning “previous/back” (for example, an equivalent of “ئالدىنقى”) so it is clearly distinct from the “Next” label.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
max-lvs
approved these changes
May 7, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: GongHeng2017, max-lvs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
Contributor
|
This pr force merged! (status: unstable) |
deepin-bot
Bot
merged commit 1da0828
into
linuxdeepin:develop/eagle
20 of 23 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--Add translate for cpu info.
Log: add feature for cpu info show.
Task: https://pms.uniontech.com/task-view-387697.html
Summary by Sourcery
Add CPU information translations and related labels across multiple locales.
New Features:
Enhancements: