Skip to content

fix: remove bubble removal animation and simplify visibility logic #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepin-bot merged 1 commit into from
Mar 12, 2026
Merged

fix: remove bubble removal animation and simplify visibility logic #1496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions panels/notification/bubble/bubblepanel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,13 +111,7 @@ void BubblePanel::onNotificationStateChanged(qint64 id, int processedType)
void BubblePanel::onBubbleCountChanged()
{
bool isEmpty = m_bubbles->items().isEmpty();
if (isEmpty) {
QTimer::singleShot(400, this, [this]() {
setVisible(false);
});
} else {
setVisible(!isEmpty && enabled());
}
setVisible(!isEmpty && enabled());
}

void BubblePanel::addBubble(qint64 id)
Expand Down
21 changes: 0 additions & 21 deletions panels/notification/bubble/package/main.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,29 +129,8 @@ Window {
}
}
delegate: Bubble {
id: delegateItem
width: 360
bubble: model

ListView.onRemove: SequentialAnimation {
PropertyAction {
target: delegateItem
property: "ListView.delayRemove"
value: true
}
NumberAnimation {
target: delegateItem
property: "x"
to: 360
duration: 400
easing.type: Easing.InExpo
}
PropertyAction {
target: delegateItem
property: "ListView.delayRemove"
value: false
}
}
}
}
}
Loading