Skip to content

fix: replace raw pointers with QPointer to prevent wild pointers #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
18202781743 merged 1 commit into from
Mar 11, 2026
Merged

fix: replace raw pointers with QPointer to prevent wild pointers #1494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions panels/dock/pluginmanagerextension_p.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,15 @@

#pragma once

#include <QtWaylandCompositor/QWaylandShellSurfaceTemplate>
#include <QtWaylandCompositor/QWaylandQuickExtension>
#include <QPointer>

Check warning on line 7 in panels/dock/pluginmanagerextension_p.h

View workflow job for this annotation

GitHub Actions / cppcheck 

Include file: <QPointer> not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <QtWaylandCompositor/QWaylandCompositor>

Check warning on line 8 in panels/dock/pluginmanagerextension_p.h

View workflow job for this annotation

GitHub Actions / cppcheck 

Include file: <QtWaylandCompositor/QWaylandCompositor> not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <QtWaylandCompositor/QWaylandSurface>
#include <QtWaylandCompositor/QWaylandQuickExtension>

Check warning on line 9 in panels/dock/pluginmanagerextension_p.h

View workflow job for this annotation

GitHub Actions / cppcheck 

Include file: <QtWaylandCompositor/QWaylandQuickExtension> not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <QtWaylandCompositor/QWaylandResource>

Check warning on line 10 in panels/dock/pluginmanagerextension_p.h

View workflow job for this annotation

GitHub Actions / cppcheck 

Include file: <QtWaylandCompositor/QWaylandResource> not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <QtWaylandCompositor/QWaylandSeat>

Check warning on line 11 in panels/dock/pluginmanagerextension_p.h

View workflow job for this annotation

GitHub Actions / cppcheck 

Include file: <QtWaylandCompositor/QWaylandSeat> not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <QtWaylandCompositor/QWaylandShellSurfaceTemplate>

Check warning on line 12 in panels/dock/pluginmanagerextension_p.h

View workflow job for this annotation

GitHub Actions / cppcheck 

Include file: <QtWaylandCompositor/QWaylandShellSurfaceTemplate> not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <QtWaylandCompositor/QWaylandSurface>

Check warning on line 13 in panels/dock/pluginmanagerextension_p.h

View workflow job for this annotation

GitHub Actions / cppcheck 

Include file: <QtWaylandCompositor/QWaylandSurface> not found. Please note: Cppcheck does not need standard library headers to get proper results.

#include <cstdint>

Check warning on line 15 in panels/dock/pluginmanagerextension_p.h

View workflow job for this annotation

GitHub Actions / cppcheck 

Include file: <cstdint> not found. Please note: Cppcheck does not need standard library headers to get proper results.

#include "qwayland-server-fractional-scale-v1.h"
#include "qwayland-server-plugin-manager-v1.h"
Expand Down Expand Up @@ -195,7 +196,7 @@

private:
PluginManager* m_manager;
QWaylandSurface* m_surface;
QPointer<QWaylandSurface> m_surface;

QString m_itemKey;
QString m_pluginId;
Expand Down Expand Up @@ -269,7 +270,7 @@

private:
PluginManager* m_manager;
QWaylandSurface* m_surface;
QPointer<QWaylandSurface> m_surface;

QString m_itemKey;
QString m_pluginId;
Expand Down
Loading