Skip to content

chore: update changelog to 2.0.24#207

Merged
robertkill merged 1 commit into
linuxdeepin:masterfrom
mhduiy:dev-changelog-2.0.24
May 14, 2026
Merged

chore: update changelog to 2.0.24#207
robertkill merged 1 commit into
linuxdeepin:masterfrom
mhduiy:dev-changelog-2.0.24

Conversation

@mhduiy
Copy link
Copy Markdown
Contributor

@mhduiy mhduiy commented May 14, 2026

更新说明

自动更新 changelog 到版本 2.0.24

变更内容

  • 更新 debian/changelog

版本信息

  • 新版本: 2.0.24
  • 目标分支: master

Summary by Sourcery

Chores:

  • Bump Debian changelog entry to version 2.0.24 targeting master.

update changelog to 2.0.24

Log: update changelog to 2.0.24
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 14, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Debian package changelog to record release 2.0.24 targeting master, with no code or packaging logic changes.

File-Level Changes

Change Details Files
Add a new 2.0.24 release entry to the Debian changelog.
  • Append or prepend a new changelog stanza for version 2.0.24 following the existing Debian changelog format.
  • Update version metadata to 2.0.24 so packaging tools recognize the new release entry.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions
Copy link
Copy Markdown

TAG Bot

TAG: 2.0.24
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

你好!我是你的智能编程助手 CodeGeeX。

针对你提供的 Git Diff 输入,我进行了仔细的审查。本次提交主要是一个 Debian 打包相关的变更记录,记录了 dde-session 版本升级至 2.0.24,并注明了性能优化:通过从配置文件读取缩放因子来优化启动时间

由于本次 Diff 仅包含 debian/changelog 的变更,没有包含实际的 C++/C 代码或脚本逻辑的修改,我将从变更日志规范以及关联代码逻辑两个维度为你提供审查意见和改进建议。


一、 针对本 Diff (debian/changelog) 的审查意见

1. 代码质量与规范

  • 格式规范性:整体符合 Debian Changelog 的标准格式(包名、版本号、发行版、紧急度、变更说明、作者与时间戳),格式无误。
  • 描述清晰度perf: optimize startup time by reading scale factor from config 描述了做了什么(从配置读取缩放因子)以及目的(优化启动时间),但稍显简略。对于深层逻辑的追踪不够友好。

改进建议
建议在 Changelog 中稍微补充一点上下文,例如之前是从哪里读取的(比如:之前是通过调用 D-Bus 接口获取,或是通过启动外部进程获取),这样可以帮助后续维护者或打包人员快速理解性能优化的核心点。

修改示例:

-  * perf: optimize startup time by reading scale factor from config
+  * perf: optimize startup time by reading scale factor directly from 
+    config instead of calling DBus interface.

2. 代码安全与逻辑

  • Changelog 本身不涉及执行逻辑,无直接安全风险。

二、 针对关联代码的审查意见(基于 Commit Message 推断)

虽然你没有提供实际修改的源码 Diff,但根据 Commit Message optimize startup time by reading scale factor from config,我可以对这种性能优化模式在语法逻辑、代码性能和代码安全方面提出潜在的审查意见和改进建议,供你在审查实际代码时对照参考:

1. 语法与逻辑

  • 配置文件读取时机的逻辑:在桌面会话启动早期,文件系统或配置系统的守护进程(如 dconfgsettings 的后端)可能尚未完全启动。如果直接读取配置文件,需要确认读取逻辑是否依赖于这些尚未就绪的服务。
  • 配置缺失的降级逻辑:直接读取配置文件时,如果配置文件不存在、被损坏或字段缺失,代码是否有合理的 Fallback(降级)逻辑?必须确保在配置缺失时返回默认的缩放因子(通常是 1.0),否则可能导致会话启动失败或 UI 异常。

2. 代码性能

  • I/O 阻塞问题:本次提交的目的是优化启动时间。如果在主线程(UI 线程)中直接使用同步 I/O(如 open, readQFile::read)去读取磁盘上的配置文件,在磁盘负载高或系统冷启动时,依然会造成线程阻塞。建议确认是否采用了异步读取,或者该配置是否已经在内存缓存中。
  • 解析开销:读取配置后通常需要解析(如 JSON、INI 等)。相比于之前的方法(如内存共享或进程间通信),文件解析的开销是否真的更小?如果解析逻辑复杂,可能并没有达到预期的性能优化效果。

3. 代码安全

  • 配置文件权限与篡改:直接从磁盘读取配置文件,会引入路径遍历非法注入的风险。如果配置文件路径是可被其他用户修改的,恶意用户可能会通过修改缩放因子配置(例如注入超长字符串或特殊字符)导致缓冲区溢出或 UI 渲染异常崩溃。
    • 改进建议:在读取配置前,检查文件的属主和权限(例如是否为 root:root 或当前用户所有,权限是否为 644),拒绝读取权限过宽的配置文件。
  • 输入校验:读取到的 scale factor 必须进行严格的边界校验。合法的缩放因子通常在 1.0 ~ 3.0 之间(或特定的离散值如 1, 1.25, 1.5, 2 等)。如果配置文件被篡改为 0、负数或极大的值,会导致 UI 缩放为0(不可见)或消耗大量显存/内存导致系统卡死。
    • 改进建议:增加严格的数值范围检查:
    float scale_factor = readScaleFromConfig();
    if (scale_factor < 1.0f || scale_factor > 3.0f) { // 假设3.0是最大合理值
        qWarning() << "Invalid scale factor:" << scale_factor << ", fallback to 1.0";
        scale_factor = 1.0f;
    }

总结

当前的 Changelog 修改格式规范,意图明确。建议在描述中稍微补充优化前的对比行为以提升可维护性。同时,强烈建议对照上述安全与逻辑审查点,检查实际读取配置文件的代码实现,确保对配置缺失、非法值、文件权限等异常情况有足够的防御性处理,避免将底层的配置文件异常暴露给上层会话导致系统启动失败。

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, robertkill

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robertkill robertkill merged commit 31f0297 into linuxdeepin:master May 14, 2026
18 of 19 checks passed
@deepin-bot
Copy link
Copy Markdown

deepin-bot Bot commented May 14, 2026

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 2.0.24
  • Tag SHA: 2d2abab192cbab19430eaa85fae38055c963f4b2
  • Commit SHA: 689825dc9bf9c3a250e28f05bf6a31d89a60560f
  • Tag Message:
    Release dde-session 2.0.24
    
    
  • Tagger:
    • Name: mhduiy
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants