kgpe-d16: add AGESA 15h coreboot fork support#2092
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for building the KGPE-D16 boards against the AGESA-based coreboot “15h” fork, updates board metadata/docs to reflect the new status, and wires the KGPE-D16 builds into CircleCI.
Changes:
- Add a new
coreboot-15hgit-fork module pinned to a specific commit. - Switch KGPE-D16 board configs to use
CONFIG_COREBOOT_VERSION=15hand simplify the per-board coreboot.configfragments. - Add KGPE-D16 jobs to the CircleCI workflow and update the boards/testers documentation.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
modules/coreboot |
Introduces the new coreboot-15h fork module and pins its commit. |
doc/BOARDS_AND_TESTERS.md |
Updates KGPE-D16 entry to reflect usage of the 15h fork. |
config/coreboot-kgpe-d16_workstation.config |
Replaces the previous full coreboot config with a minimal fragment for the KGPE-D16 workstation variant. |
config/coreboot-kgpe-d16_workstation-usb_keyboard.config |
Same as above for workstation USB keyboard variant. |
config/coreboot-kgpe-d16_server.config |
Same as above for server variant. |
config/coreboot-kgpe-d16_server-whiptail.config |
Same as above for server-whiptail variant. |
boards/kgpe-d16_workstation/kgpe-d16_workstation.config |
Switches board to CONFIG_COREBOOT_VERSION=15h and adds board notes. |
boards/kgpe-d16_workstation-usb_keyboard/kgpe-d16_workstation-usb_keyboard.config |
Switches board to CONFIG_COREBOOT_VERSION=15h and adds board notes. |
boards/kgpe-d16_server/kgpe-d16_server.config |
Switches board to CONFIG_COREBOOT_VERSION=15h. |
boards/kgpe-d16_server-whiptail/kgpe-d16_server-whiptail.config |
Switches board to CONFIG_COREBOOT_VERSION=15h. |
.circleci/config.yml |
Adds KGPE-D16 builds to CI (but currently with target naming/caching issues). |
Comments suppressed due to low confidence (4)
boards/kgpe-d16_workstation-usb_keyboard/kgpe-d16_workstation-usb_keyboard.config:15
- Typo in board notes: "work around" should be "workaround".
boards/kgpe-d16_workstation/kgpe-d16_workstation.config:18 - Typo in board notes: "work around" should be the single word "workaround".
boards/kgpe-d16_workstation/kgpe-d16_workstation.config:18 - Typo in board notes: "trubble" should be "trouble".
boards/kgpe-d16_workstation-usb_keyboard/kgpe-d16_workstation-usb_keyboard.config:15 - Typo in board notes: "trubble" should be "trouble".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
83aeb1d to
cbfa0b1
Compare
558bb90 to
effed43
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 30 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (4)
boards/kgpe-d16_workstation-tpm1/kgpe-d16_workstation-tpm1.config:27
- CONFIG_COREBOOT_VERSION was switched to the new 15h fork, but this board still points CONFIG_COREBOOT_CONFIG at config/coreboot-kgpe-d16_workstation.config, which does not exist (only -tpm1/-tpm2 coreboot configs are present). This will break builds; update the path to the correct kgpe-d16_workstation-tpm1 coreboot config file.
boards/kgpe-d16_server-whiptail-tpm1/kgpe-d16_server-whiptail-tpm1.config:25 - This board now uses CONFIG_COREBOOT_VERSION=15h, but CONFIG_COREBOOT_CONFIG still points to config/coreboot-kgpe-d16_server-whiptail.config, which is not present (only *-server-whiptail-tpm1/tpm2 configs exist). Update CONFIG_COREBOOT_CONFIG to the correct kgpe-d16_server-whiptail-tpm1 coreboot config so the board builds successfully.
boards/kgpe-d16_workstation-usb_keyboard-tpm1/kgpe-d16_workstation-usb_keyboard-tpm1.config:24 - This board still references config/coreboot-kgpe-d16_workstation-usb_keyboard.config, but the repo only contains the new -usb_keyboard-tpm1/-usb_keyboard-tpm2 coreboot config filenames. This mismatch will cause
make BOARD=kgpe-d16_workstation-usb_keyboard-tpm1to fail; update CONFIG_COREBOOT_CONFIG to the correct *-tpm1 file.
boards/kgpe-d16_server-tpm1/kgpe-d16_server-tpm1.config:23 - This board now uses CONFIG_COREBOOT_VERSION=15h, but CONFIG_COREBOOT_CONFIG points to config/coreboot-kgpe-d16_server.config, which is not present in the repo (only coreboot-kgpe-d16_server-tpm1/tpm2 configs exist). Update the path to the correct kgpe-d16_server-tpm1 coreboot config to avoid build failures.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
effed43 to
a563c07
Compare
|
as per BOARDS_AND_TESTERS.md, testing and review needed. specify which variant you tested, will move others to untested before merging |
a563c07 to
89c847c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 30 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
89c847c to
56ffddf
Compare
54f6018 to
95af626
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 30 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c9d53b9 to
8890032
Compare
77fef73 to
58b0c58
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 34 out of 34 changed files in this pull request and generated 7 comments.
Comments suppressed due to low confidence (5)
boards/kgpe-d16_workstation/kgpe-d16_workstation.config:18
- Typo: "work around" should be "workaround".
boards/kgpe-d16_workstation/kgpe-d16_workstation.config:18 - Typo: "trubble" should be "trouble".
boards/kgpe-d16_workstation-usb_keyboard/kgpe-d16_workstation-usb_keyboard.config:15 - Typo: "work around" should be "workaround".
boards/kgpe-d16_workstation-usb_keyboard/kgpe-d16_workstation-usb_keyboard.config:16 - Typo: "trubble" should be "trouble".
boards/kgpe-d16_workstation/kgpe-d16_workstation.config:17 - Typo/consistency: "qubes" should be capitalized as "Qubes" (as used elsewhere in the sentence).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9e3beb4 to
ebf3a39
Compare
ebf3a39 to
86963db
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 34 out of 34 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
656aefb to
c789796
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 34 out of 34 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
boards/kgpe-d16_server-whiptail/kgpe-d16_server-whiptail.config:25
- This whiptail board config uses the BMC serial console (ttyS1), but the referenced coreboot config (
config/coreboot-kgpe-d16_server-whiptail-tpm1.config) currently setsCONFIG_LINUX_COMMAND_LINEtoconsole=tty0. That mismatch can hide early output / break headless boot. Please update the coreboot config command line to use ttyS1 (consistent with the TPM2 whiptail variant).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5cd0412 to
dda575e
Compare
- Add coreboot-15h module pointing to AGESA-based 15h fork - Move kgpe-d16 boards from UNMAINTAINED to maintained - Add TPM1 and TPM2 board variants with proper coreboot configs - Add defconfig and oldconfig helper targets documentation - Update CircleCI config to build kgpe-d16 boards - Add board documentation referencing 15h.org wiki Supersedes #1931 Signed-off-by: Thierry Laurion <insurgo@riseup.net>
dda575e to
426750a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 35 out of 35 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add coreboot-15h module pointing to AGESA-based 15h fork - Move kgpe-d16 boards from UNMAINTAINED to maintained - Add TPM1 and TPM2 board variants with proper coreboot configs - Add defconfig and oldconfig helper targets documentation - Update CircleCI config to build kgpe-d16 boards - Add board documentation referencing 15h.org wiki Supersedes #1931 Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…-d16-15h-coreboot Signed-off-by: Thierry Laurion <insurgo@riseup.net> # Conflicts: # modules/coreboot
Summary
Changes
New Module
Board Variants (8 total)
TPM Configuration
Initial Flash (REQUIRED)
Board Documentation
Workstation GPU Support
CircleCI
Known Issues
Supersedes #1931