Skip to content

test: fix unit test module lookup paths#876

Merged
richm merged 1 commit into
linux-system-roles:mainfrom
richm:test-unit-test-paths
Jun 1, 2026
Merged

test: fix unit test module lookup paths#876
richm merged 1 commit into
linux-system-roles:mainfrom
richm:test-unit-test-paths

Conversation

@richm

@richm richm commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

fix unit test module lookup paths

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by CodeRabbit

  • Bug Fixes
    • Fixed collection discovery path enumeration in test setup to correctly identify collection directories during iteration.

fix unit test module lookup paths

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dec03310-e285-4f7b-b403-d6842676ebf4

📥 Commits

Reviewing files that changed from the base of the PR and between 82f252d and 3eccdee.

📒 Files selected for processing (1)
  • tests/tasks/setup_remote_pytest.yml

📝 Walkthrough

Walkthrough

The remote pytest setup playbook corrects a bash glob expansion issue in its collection-discovery loop. The glob pattern is restructured to properly split the directory variable from the wildcard pattern, enabling correct enumeration of subdirectories under the ansible_collections path.

Changes

Collection discovery glob fix

Layer / File(s) Summary
Collection discovery glob expansion fix
tests/tasks/setup_remote_pytest.yml
The for collections_dir in ... bash glob is restructured from a fully quoted glob to "$dir/ansible_collections"/*/* so that glob expansion occurs correctly under the collections path during iteration.
🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and lacks the required template sections (Enhancement, Reason, Result, Issue Tracker Tickets). Add the missing template sections with detailed information about why this change was needed and what it accomplishes.
Description Format ⚠️ Warning PR description does not follow the required template structure from .github/pull_request_template.md - missing Enhancement/Feature, Reason, and Result sections. Update PR description to include Enhancement/Feature, Reason, and Result sections following the template defined in .github/pull_request_template.md.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows Conventional Commits format with 'test' type and clear description of the change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.19%. Comparing base (1b57520) to head (3eccdee).
⚠️ Report is 103 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #876      +/-   ##
==========================================
+ Coverage   43.11%   43.19%   +0.07%     
==========================================
  Files          12       13       +1     
  Lines        3124     3172      +48     
==========================================
+ Hits         1347     1370      +23     
- Misses       1777     1802      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richm

richm commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

[citest]

@richm richm merged commit 3c4717c into linux-system-roles:main Jun 1, 2026
48 of 49 checks passed
@richm richm deleted the test-unit-test-paths branch June 1, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant