Skip to content

wdc: fix null pointer dereference in get_dev_mgmt_log_page_lid_data() #3579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LJaved-IBM wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −6
Open

wdc: fix null pointer dereference in get_dev_mgmt_log_page_lid_data() #3579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions plugins/wdc/wdc-nvme.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2460,11 +2460,6 @@ bool wdc_get_dev_mng_log_entry(__u32 log_length, __u32 entry_id,
__u32 offset = 0;
struct wdc_c2_log_subpage_header *p_next_log_entry = NULL;

if (!*p_p_found_log_entry) {
fprintf(stderr, "ERROR: WDC - %s: No ppLogEntry pointer.\n", __func__);
return false;
}

*p_p_found_log_entry = NULL;

/* Ensure log data is large enough for common header */
Expand Down Expand Up @@ -2693,7 +2688,7 @@ static bool get_dev_mgmt_log_page_lid_data(struct libnvme_transport_handle *hdl,
/* Check the log data to see if the WD version of log page ID's is found */
length = sizeof(struct wdc_c2_log_page_header);
hdr_ptr = (struct wdc_c2_log_page_header *)data;
sph = (struct wdc_c2_log_subpage_header *)(data + length);
sph = NULL;
found = wdc_get_dev_mng_log_entry(le32_to_cpu(hdr_ptr->length), log_id, hdr_ptr, &sph);
if (found && sph) {
*cbs_data = calloc(le32_to_cpu(sph->length), sizeof(__u8));
Expand Down