libnvme: add CIU and CIRN to Identify Controller data structure#3426
Open
MaisenbacherD wants to merge 1 commit into
Open
libnvme: add CIU and CIRN to Identify Controller data structure#3426MaisenbacherD wants to merge 1 commit into
MaisenbacherD wants to merge 1 commit into
Conversation
The I/O Command Set Independent Identify Controller data structure (Figure 328 in NVM Express Base Specification 2.3) defines two fields that were previously hidden inside the rsvd135[118] reserved block: - byte 135 Controller Instance Uniquifier (CIU) - bytes 143:136 Controller Instance Random Number (CIRN) Split rsvd135[118] into ciu, cirn[8], and the two remaining reserved ranges. Signed-off-by: Dennis Maisenbacher <dennis.maisenbacher@wdc.com> Assisted-by: Claude:claude-opus-4-8 [devin]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@igaw As we discussed at Lund Linux Conference, I took the spec and cross-referenced it with the code base to an LLM. It found some discrepancies. Here is the first one. Please let me know if this is useful, I will then continue sending the next ones in batches after manually checking the mismatches. :)
Commit description :
The I/O Command Set Independent Identify Controller data structure (Figure 328 in NVM Express Base Specification 2.3) defines two fields that were previously hidden inside the rsvd135[118] reserved block:
Split rsvd135[118] into ciu, cirn[8], and the two remaining reserved ranges.
Assisted-by: Claude:claude-opus-4-8 [devin]