Merged
Conversation
The ioctl probing needs to be a bit smarter to avoid kernel logging invalid commands. At least set the NSID correctly. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Replace the open coded version of exec_cmd with this helper. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Add Python's logger framework and log all commands input/output, in order to be able to debug failures. Signed-off-by: Daniel Wagner <wagi@kernel.org>
To allow debugging failures, enable the debug level on default. Signed-off-by: Daniel Wagner <wagi@kernel.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a bit hard to debug any failures with the current Python tests. So log all input/output of the commands, which should help to figure out what's going on when something fails.
Fixes: #3247