Skip to content

fabrics: use uuid from hostnqn for hostid #3223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igaw merged 1 commit into from
Apr 1, 2026
Merged

fabrics: use uuid from hostnqn for hostid #3223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions libnvme/src/nvme/fabrics.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,10 +274,26 @@ __public int nvmf_context_set_connection(struct nvmf_context *fctx,
return 0;
}

static const char *hostid_from_hostnqn(const char *hostnqn)
{
const char *match;

if (!hostnqn)
return NULL;

match = strstr(hostnqn, "uuid:");
if (!match)
return NULL;

return match + strlen("uuid:");
}

__public int nvmf_context_set_hostnqn(struct nvmf_context *fctx,
const char *hostnqn, const char *hostid)
{
fctx->hostnqn = hostnqn;
if (!hostid)
hostid = hostid_from_hostnqn(hostnqn);
fctx->hostid = hostid;

return 0;
Expand Down
2 changes: 2 additions & 0 deletions libnvme/src/nvme/tree.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,6 +631,8 @@ static int nvme_create_host(struct nvme_global_ctx *ctx, const char *hostnqn,
return -ENOMEM;

h->hostnqn = strdup(hostnqn);
if (!hostid)
hostid = nvme_hostid_from_hostnqn(hostnqn);
if (hostid)
h->hostid = strdup(hostid);
list_head_init(&h->subsystems);
Expand Down
Loading