Convert libnvme to 'struct nvmf_context' as function argument#3203
Merged
igaw merged 10 commits intolinux-nvme:masterfrom Mar 23, 2026
Merged
Convert libnvme to 'struct nvmf_context' as function argument#3203igaw merged 10 commits intolinux-nvme:masterfrom
igaw merged 10 commits intolinux-nvme:masterfrom
Conversation
To simplify the interface. Signed-off-by: Hannes Reinecke <hare@suse.de>
To simplify the interface. Signed-off-by: Hannes Reinecke <hare@suse.de>
To simplify the interface. Signed-off-by: Hannes Reinecke <hare@suse.de>
Separate out _nvme_create_ctrl() as a simpler interface to nvme_create_ctrl() which accepts a 'struct nvmf_context' as argument. Signed-off-by: Hannes Reinecke <hare@suse.de>
…ntry() To simplify the interface. Signed-off-by: Hannes Reinecke <hare@suse.de>
To simplify the interface. Signed-off-by: Hannes Reinecke <hare@suse.de>
Replace with nvme_ctrl_find() and make it static to avoid function name clashes. Signed-off-by: Hannes Reinecke <hare@suse.de>
Re-implement __nvme_lookup_ctrl() as equivalent to nvme_lookup_ctrl() but taking 'struct nvmf_context' as argument. Care needs to be taken to handle the 'subsysnqn' entry in 'struct nvmf_context'; __nvme_ctrl_find() needs to be called with a 'NULL' subsysnqn as the controller might be on any subsystem, and we need to set 'subsysnqn' to the NQN of the subsystem the controller should be created in rather than the subsysnqn from 'struct nvmf_context' (which might be empty). Signed-off-by: Hannes Reinecke <hare@suse.de>
Use 'struct nvmf_context' throughout the file to test the new interface. Signed-off-by: Hannes Reinecke <hare@suse.de>
All functions have been converted to the new interface, so rename __nvme_lookup_ctrl() to nvme_lookup_ctrl() and drop the wrapper. Signed-off-by: Hannes Reinecke <hare@suse.de>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert all callers using separate fabrics arguments like 'transport', 'traddr' etc to use 'struct nvmf_context' instead.