Add TWSC NVMe plugin foldernit__.py

[Owen-kaiqi]

This PR adds a new folder for TWSC NVMe device support.

[igaw]

Not sure where this is heading using Python. I want to see some more code before accepting this. I mark this PR as draft, please add some more code. Thanks

[Owen-kaiqi]

Not sure where this is heading using Python. I want to see some more code before accepting this. I mark this PR as draft, please add some more code. Thanks

Thanks for the feedback! I've added the three implementation files for the TWSC plugin: twsc-nvme.c, twsc-nvme.h, and twsc-types.h. They're ready for your review now.

[igaw]

Sorry, for coming back so late. I was a bit away from the keyboard :)

Could you rebase your work to the latest master? There were a bunch of changes in the build system and I think you need to look into this part as it doesn't compile right now. Please also have a look at the checkpatch warnings.

FWIW, it looks fairly okay from a quick glance.

[Owen-kaiqi]

Sorry, for coming back so late. I was a bit away from the keyboard :)

Could you rebase your work to the latest master? There were a bunch of changes in the build system and I think you need to look into this part as it doesn't compile right now. Please also have a look at the checkpatch warnings.

FWIW, it looks fairly okay from a quick glance.

Thank you for the review. I'll work on these points right away.

[igaw]

I though it's done and did some reformatting. First I rebased all changed and let checkpatch fix the errors. After that I spend way too long adding newlines before I realized this plugin needs to be updated against the new APIs. There is no struct nvme_dev anymore. We are working on the 3.x version and have a few API changes. Basically you need to use nvme_global_ctx and nvme_transport_handle now. Have a look at the recent changes in other plugins.

Anyway my attempt of reformatting is here: https://github.com/igaw/nvme-cli/tree/twsc

Please update your code accordingly. Thanks.