-
Notifications
You must be signed in to change notification settings - Fork 20
For linux msm/flashing support #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andersson
wants to merge
10
commits into
linux-msm:master
Choose a base branch
from
quic-bjorande:for-linux-msm/flashing-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a3adbc2
list: Clarify list_add(), add list_prepend() and list_len()
quic-bjorande 6ef5e38
cdba-server: Allow booting into EDL mode
quic-bjorande 403e5c3
drivers: ftdi-gpio: Implement support for EDL key
quic-bjorande fc100a6
cdba-server: Add support for flashing, using QDL
quic-bjorande 627e5f1
cdba: Clean up construction of TX messages
quic-bjorande 1b75e1a
cdba: Allow queueing file descriptors
quic-bjorande 40ced5a
cdba: Wire up flashing support in the client
quic-bjorande 7af96ab
cdba: Consider stdin and stderr for inactivity timer as well
quic-bjorande 4be6c26
device_parser: Extract parsing of "users"
quic-bjorande 5835cb4
cdba-server: Provide QDL access control list
quic-bjorande File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to bump the timeout timer somewhere around here,, as qdl flashing may take a very long time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, although the timeout is client side - and the question is how much time one should implicitly allocate for this operation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could utilize cdba's
ux_progressand waitmax(default_timeout, user_timeout)between each response?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, the flash process does provide log output which results in a stream of updates for which we could nudge the inactivity timeout. It's arriving on stderr though, for which we today don't nudge the timeout. In the event that the flash process is silent (like in cdba-axiom), this could become a problem - but perhaps worth looking at separately.
The other case where we do have a problem is the upload of large images, both MSG_FASTBOOT_DOWNLOAD and MSG_EDL_DOWNLOAD will produce a stream of packets only on "stdin", which also doesn't nudge the inactivity timeout.
It seems conceptually reasonable to me to nudge the inactivity timeout in both these cases; they are both signs of activity.