client: Accept application/json as Text#537
Merged
Merged
Conversation
Collaborator
|
Right, defaulting to blob seems sane but i kind of intentionally made it crash on early versions of the daemon to collect what mimetypes are out there in the wild so i can design the API better in the future. |
Contributor
Author
|
Understandable. In that case, consider |
Collaborator
that would require pulling serde_json, so for now let us keep it as is and we will see later. |
bilelmoussaoui
merged commit Jul 24, 2026
ee9c75b
into
linux-credentials:main
15 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ContentTypecurrently does not acceptapplication/jsonMIME type, which breaks apps like aws-vault.This PR adds
application/jsonas an acceptableTextsecret (since JSON is always a valid UTF-8) and keeps the Text/Blob distinction and MIME parameter parsing intact.Tested with
aws-vaultin my NixOS setup:aws-vault: error: add: Invalid content type: application/jsonA more generic fix for this type of errors might be to map every unrecognized content type to
Blobinstead of rejecting them.Let me know what you think!