Conversation
linuswillner
left a comment
There was a problem hiding this comment.
Just a few small nits, otherwise good.
(Historical note: This library is indeed probably a potent candidate to have performance problems, given how old some of the code is. It should be rewritten in TypeScript and all that jazz, but time is finite.)
|
Sorry for spamming commits, I just kept remembering that I could make things a bit better. |
|
No problem, sorry for the delay - I don't really check in on this repo that often. I had one more suggestion but otherwise I think this is good. |
Don't worry about the delay, I know you're busy and that you provided this project in your free time! Thank you for all the work you've put into refining this feature. Appreciate the help! |
I noticed while using react-console-emulator, that the terminal can get very laggy when many high-speed
terminal.pushToStdout()occur, and it gets much worse when the terminal output begins to be the length of millions. Implementing a solution using refs would be painful, and I think it would be much more reasonable to add the option for other people to use, as it is only one line of code.