upcoming: [UIE 9401] – Implement Share Groups Landing page tabs by fabrice-akamai · Pull Request #13471 · linode/manager

fabrice-akamai · 2026-03-05T20:37:55Z

Description 📝

This PR implements the Share Groups Landing page and its corresponding subtabs:

Owned groups
Joined groups
My membership requests.

This feature builds upon the existing work on the Image Library tabs and lays the groundwork for the Share groups implementation under the isPrivateImageSharingEnable feature flag.

Changes 🔄

List any change(s) relevant to the reviewer.

Added ShareGroupsTabs.tsx and ShareGroupsTabsConfig.tsx
Updated the share groups route and index route
Updated getImageLibrarySubTabIndex to be more generic so the Share Groups tab can reuse the same logic
Added unit test for ShareGroupsTabs.tsx

Scope 🚢

Upon production release, changes in this PR will be visible to:

All customers
Some customers (e.g. in Beta or Limited Availability)
No customers / Not applicable

Target release date 🗓️

Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

Preview 📷

Before	After

How to test 🧪

Prerequisites

(How to setup test environment)

Make sure the isPrivateImageSharingEnabled is enabled for testing the feature under the new Images page

Reproduction steps

Verification steps

(How to verify changes)

Navigate to localhost:3000/images/
Click on the Share Groups tab
Click each of the sub-tabs and make sure they all render the coming soon notice

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

All tests and CI checks are passing
TypeScript compilation succeeded without errors
Code passes all linting rules

…nto develop

…into UIE-9401

pmakode-akamai

thanks @fabrice-akamai! This looks good to me 👍 Could we also add a Upcoming Features changeset for this PR?

packages/manager/src/features/Images/utils.test.tsx

packages/manager/src/routes/images/index.ts

abailly-akamai · 2026-03-09T13:19:13Z

packages/manager/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsTabs.tsx

+                    Membership Requests is coming soon...
+                  </Notice>
+                )}
+              </SafeTabPanel>


Why are we not using routed tabs here? See other examples with lazy routes + Outlet

Do we also need the Outlet placeholder here? I saw that it was implemented by the parent component ImagesLandingV2, but looking at the corresponding ImageLibraryTabs, I noticed that the SafeTabPanels are rendered directly in the file without using Outlet. Can you confirm if I need to add it to both files?

Ideally yes, since the use of SafeTabPanels should be deprecated (need to do a PR for that). This could however be a follow up if you'd like to keep the PR's scope narrower

Sure, I can create a follow-up ticket to replace the use of SafeTabPanels so we can merge this PR if it's non-blocking.

dwiley-akamai

Verification steps & tab functionality ✅

Will do another pass of the PR once the routed tabs have been implemented

packages/manager/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsTabs.tsx

Co-authored-by: Purvesh Makode <pmakode@akamai.com>

…into UIE-9401

linode-gh-bot · 2026-03-09T21:46:27Z

Cloud Manager UI test results

🔺 4 failing tests on test run #7 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`4 Failing`	`868 Passing`	`11 Skipped`	`38m 12s`

Details

Failing Tests
	Spec	Test
❌	`account-switching.spec.ts`	Cloud Manager Cypress Tests→Parent/Child account switching→From Parent to Child » can search child accounts
❌	`account-switching.spec.ts`	Cloud Manager Cypress Tests→Parent/Child account switching→From Child to Parent » can switch from Proxy user back to Parent account user from Billing page
❌	`account-switching.spec.ts`	Cloud Manager Cypress Tests→Parent/Child account switching→From Child to Child » can switch to another Child account as a Proxy user
❌	`object-storage.e2e.spec.ts`	Cloud Manager Cypress Tests→object storage end-to-end tests » can create and delete object storage buckets

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/parentChild/account-switching.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts"

dwiley-akamai

Approving as the routed tabs will be implemented in a follow-up PR.

packages/manager/.changeset/pr-13471-upcoming-features-1773085243886.md

…243886.md Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

…de#13471) * Added missing padding around the Managed dashboard card * changed spacing to spacingFunction * Implement share groups landing page tabs * Update image subtab interface * Fix image utils test case * Update packages/manager/src/features/Images/utils.test.tsx Co-authored-by: Purvesh Makode <pmakode@akamai.com> * Added changeset: Add share groups tabs * Update file name and consolidate imports * Rename file for consistency * Update packages/manager/.changeset/pr-13471-upcoming-features-1773085243886.md Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com> --------- Co-authored-by: Purvesh Makode <pmakode@akamai.com> Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

fabrice-akamai added 6 commits September 26, 2025 10:40

Added missing padding around the Managed dashboard card

8680aae

changed spacing to spacingFunction

d53e3f6

Merge branch 'develop' of https://github.com/fabrice-akamai/manager i…

ef5485f

…nto develop

Merge branch 'develop' of https://github.com/fabrice-akamai/manager i…

2a8188d

…nto develop

Implement share groups landing page tabs

f3cc61e

Update image subtab interface

f61754c

github-project-automation bot added this to Cloud Manager Mar 5, 2026

github-project-automation bot moved this to Review in Cloud Manager Mar 5, 2026

fabrice-akamai added 3 commits March 5, 2026 15:46

Merge branch 'develop' into UIE-9401

1c4e90f

Fix image utils test case

55e5bbd

Merge branch 'UIE-9401' of https://github.com/fabrice-akamai/manager …

76eb464

…into UIE-9401

fabrice-akamai marked this pull request as ready for review March 5, 2026 21:48

fabrice-akamai requested a review from a team as a code owner March 5, 2026 21:48

fabrice-akamai requested review from abailly-akamai, dwiley-akamai and pmakode-akamai March 5, 2026 21:48

pmakode-akamai assigned fabrice-akamai Mar 9, 2026

pmakode-akamai added the Private Image Sharing Related to Private Image Sharing feature label Mar 9, 2026

pmakode-akamai approved these changes Mar 9, 2026

View reviewed changes

packages/manager/src/features/Images/utils.test.tsx Outdated Show resolved Hide resolved

packages/manager/src/routes/images/index.ts Outdated Show resolved Hide resolved

pmakode-akamai added the Missing Changeset label Mar 9, 2026

abailly-akamai reviewed Mar 9, 2026

View reviewed changes

dwiley-akamai reviewed Mar 9, 2026

View reviewed changes

packages/manager/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsTabs.tsx Outdated Show resolved Hide resolved

fabrice-akamai and others added 5 commits March 9, 2026 13:08

Update packages/manager/src/features/Images/utils.test.tsx

20caa83

Co-authored-by: Purvesh Makode <pmakode@akamai.com>

Added changeset: Add share groups tabs

23341f6

Update file name and consolidate imports

50b7a3e

Merge branch 'UIE-9401' of https://github.com/fabrice-akamai/manager …

d892901

…into UIE-9401

Rename file for consistency

23eb7e2

dwiley-akamai approved these changes Mar 10, 2026

View reviewed changes

packages/manager/.changeset/pr-13471-upcoming-features-1773085243886.md Outdated Show resolved Hide resolved

github-project-automation bot moved this from Review to Approved in Cloud Manager Mar 10, 2026

fabrice-akamai and others added 2 commits March 10, 2026 13:16

Update packages/manager/.changeset/pr-13471-upcoming-features-1773085…

7ce6f09

…243886.md Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

Merge branch 'develop' into UIE-9401

5306ce9

fabrice-akamai merged commit e12261f into linode:develop Mar 10, 2026
34 of 35 checks passed

github-project-automation bot moved this from Approved to Merged in Cloud Manager Mar 10, 2026

fabrice-akamai deleted the UIE-9401 branch March 10, 2026 18:07

This was referenced Mar 11, 2026

Release v1.160.0 - release → staging #13478

Merged

Release v1.160.0 - staging → master #13488

Merged

pmakode-akamai removed the Missing Changeset label Mar 17, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upcoming: [UIE 9401] – Implement Share Groups Landing page tabs#13471

upcoming: [UIE 9401] – Implement Share Groups Landing page tabs#13471
fabrice-akamai merged 16 commits intolinode:developfrom
fabrice-akamai:UIE-9401

fabrice-akamai commented Mar 5, 2026 •

edited

Loading

Uh oh!

pmakode-akamai left a comment

Uh oh!

Uh oh!

Uh oh!

abailly-akamai Mar 9, 2026

Uh oh!

fabrice-akamai Mar 9, 2026

Uh oh!

abailly-akamai Mar 10, 2026

Uh oh!

fabrice-akamai Mar 10, 2026

Uh oh!

dwiley-akamai left a comment

Uh oh!

Uh oh!

linode-gh-bot commented Mar 9, 2026

Uh oh!

dwiley-akamai left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

fabrice-akamai commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description 📝

Changes 🔄

Scope 🚢

Target release date 🗓️

Preview 📷

How to test 🧪

Prerequisites

Reproduction steps

Verification steps

As an Author, to speed up the review process, I considered 🤔

As an Author, before moving this PR from Draft to Open, I confirmed ✅

Uh oh!

pmakode-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

abailly-akamai Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

fabrice-akamai Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

abailly-akamai Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

fabrice-akamai Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

dwiley-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

linode-gh-bot commented Mar 9, 2026

Cloud Manager UI test results

🔺 4 failing tests on test run #7 ↗︎

Details

Troubleshooting

Uh oh!

dwiley-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fabrice-akamai commented Mar 5, 2026 •

edited

Loading