Skip to content

fix: [DPS-41226][CMJPOC-7] - Errors while searching for services in cloud manager#13459

Open
kagora-akamai wants to merge 3 commits intolinode:developfrom
kagora-akamai:bugfix/DPS-41226-errrors-while-searching-for-services-in-cloude
Open

fix: [DPS-41226][CMJPOC-7] - Errors while searching for services in cloud manager#13459
kagora-akamai wants to merge 3 commits intolinode:developfrom
kagora-akamai:bugfix/DPS-41226-errrors-while-searching-for-services-in-cloude

Conversation

@kagora-akamai
Copy link
Contributor

Description 📝

Fix for Search bar for users without access to beta Logs tab.

Changes 🔄

  • search bar queries for Destinations and Streams disabled when user does not have a flag aclpLogs enabled.

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • Some customers (e.g. in Beta or Limited Availability)

Target release date 🗓️

March 2026

Preview 📷

Before After
Screenshot 2026-03-04 at 08 46 28 Screenshot 2026-03-04 at 08 45 35

How to test 🧪

Prerequisites

  • Start manager
  • Turn off access to Logs feature
devTools/mock-feature-flags: {"aclpLogs":{"enabled":false,"beta":true}}

Verification steps

Search for something in main search bar and observe requests in Network devtools tab.

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@kagora-akamai kagora-akamai requested a review from a team as a code owner March 4, 2026 07:50
@kagora-akamai kagora-akamai marked this pull request as draft March 4, 2026 07:50
@kagora-akamai kagora-akamai self-assigned this Mar 4, 2026
@kagora-akamai kagora-akamai marked this pull request as ready for review March 4, 2026 07:53
@mduda-akamai
Copy link
Contributor

Is it possible to add streams' and destinations' Created time to the results?

@kagora-akamai kagora-akamai added the Add'tl Approval Needed Waiting on another approval! label Mar 5, 2026
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 8 failing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
8 Failing861 Passing11 Skipped37m 24s

Details

Failing Tests
SpecTest
edit-system-alert.spec.tsCloud Manager Cypress Tests→Integration Tests for Edit Alert » should navigate from the Alert Definitions List page to the Edit Alert page
object-storage.e2e.spec.tsCloud Manager Cypress Tests→object storage end-to-end tests » can create and delete object storage buckets
object-storage.e2e.spec.tsCloud Manager Cypress Tests→object storage end-to-end tests » can update bucket access
alerts-listing-page.spec.tsCloud Manager Cypress Tests→Integration Tests for CloudPulse Alerts Listing Page » should validate UI elements and alert details
alerts-listing-page.spec.tsCloud Manager Cypress Tests→Integration Tests for CloudPulse Alerts Listing Page » should search and filter alerts by name, service, and status, and clear filters
account-switching.spec.tsCloud Manager Cypress Tests→Parent/Child account switching→From Parent to Child » can search child accounts
account-switching.spec.tsCloud Manager Cypress Tests→Parent/Child account switching→From Child to Parent » can switch from Proxy user back to Parent account user from Billing page
account-switching.spec.tsCloud Manager Cypress Tests→Parent/Child account switching→From Child to Child » can switch to another Child account as a Proxy user

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/cloudpulse/edit-system-alert.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts,cypress/e2e/core/cloudpulse/alerts-listing-page.spec.ts,cypress/e2e/core/parentChild/account-switching.spec.ts"

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verification steps ✅
Code review ✅

"@linode/manager": Fixed
---

Errors while searching for Delivery services in cloud manager ([#13459](https://github.com/linode/manager/pull/13459))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Errors while searching for Delivery services in cloud manager ([#13459](https://github.com/linode/manager/pull/13459))
Unnecessary API requests for Delivery services while searching when feature access is not present ([#13459](https://github.com/linode/manager/pull/13459))

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Mar 5, 2026
@@ -143,6 +146,7 @@ const entities = [
*/
export const useAPISearch = ({ enabled, query }: Props) => {
const deboundedQuery = useDebouncedValue(query);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: debounded looks like a typo, could rename this to debouncedQuery since there are changes to this file already in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Add'tl Approval Needed Waiting on another approval! Logs

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

4 participants