Open
Conversation
guilhem
had a problem deploying
to
prod-external
GitHub Actions
Failure
guilhem
had a problem deploying
to
prod-external
GitHub Actions
Failure
If controller encounter a auth error (token invalid), error stay silent to user
guilhem
had a problem deploying
to
prod-external
GitHub Actions
Failure
guilhem
had a problem deploying
to
prod-external
GitHub Actions
Failure
guilhem
had a problem deploying
to
prod-external
GitHub Actions
Failure
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1001 +/- ##
==========================================
+ Coverage 66.97% 67.00% +0.02%
==========================================
Files 71 71
Lines 6380 6391 +11
==========================================
+ Hits 4273 4282 +9
- Misses 1814 1815 +1
- Partials 293 294 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eljohnson92
reviewed
Jan 20, 2026
| // Only set failure reason if the error is not retryable. | ||
| if linodego.ErrHasStatus(err, http.StatusBadRequest) { | ||
| // Set specific failure reason for authentication errors | ||
| if util.IsAuthenticationError(err) { |
Collaborator
There was a problem hiding this comment.
I think we want to use a Ready=false condition with a message over setting the failure reason
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If the controller encounters an auth error (token invalid), the error stays silent to the user.
log error example:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: