fix: duplicate name check

[dennisvankekem]

Considerations

• I have tested the changes in both light and dark mode.
• I have considered the need for new unit tests.
• I have tested the changes on a cluster.
• I have included relevant documentation updates.
• I have an approved Figma design or have reflected my changes in Figma
• I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
• I have tested the changes for responsiveness in different screen resolutions.
• I have tested expected error states and verified that the user is presented with informative error messages.
• I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).

[Copilot]

Pull request overview

Adds a shared Yup validator to enforce case/whitespace-insensitive uniqueness for resource names, and wires it into multiple create/edit forms by passing existing names via react-hook-form resolver context.

Changes:

• Introduces uniqueNameTest (normalized duplicate check with optional “current name” exclusion).
• Applies the duplicate-name test across workload/team/service/secret/netpol/code-repo/catalog schemas and supplies existingNames/currentName from relevant queries.
• Adds/extends unit tests for the new validator and several schemas (teams, services, catalogs, code repositories, builds).

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
src/utils/uniqueName.validator.ts	New shared Yup test for normalized uniqueness checks.
src/utils/uniqueName.validator.test.ts	Unit tests for the shared uniqueness test behavior.
src/pages/workloads/create-edit/WorkloadsCreateEditPage.tsx	Fetches team workloads to supply existing names to form context.
src/pages/workloads/create-edit/create-edit-workloads.validator.ts	Adds uniqueness validation to workload name.
src/pages/teams/create-edit/TeamsCreateEditPage.tsx	Fetches teams to supply existing names to form context.
src/pages/teams/create-edit/create-edit-teams.validator.ts	Adds uniqueness validation to team name.
src/pages/teams/create-edit/create-edit-teams.validator.test.ts	New tests covering team name uniqueness behavior.
src/pages/services/create-edit/ServicesCreateEditPage.tsx	Fetches team services, filters K8s service options, supplies existing names to form context.
src/pages/services/create-edit/create-edit-services.validator.ts	Adds uniqueness validation to service name.
src/pages/services/create-edit/create-edit-services.validator.test.ts	New tests covering service name uniqueness behavior.
src/pages/secrets/team/create-edit/SecretCreateEditPage.tsx	Fetches sealed secrets to supply existing names to form context.
src/pages/secrets/team/create-edit/create-edit-secrets.validator.ts	Adds uniqueness validation to sealed secret name.
src/pages/network-policies/create-edit/NetworkPoliciesIngressCreateEditPage.tsx	Fetches team netpols to supply existing names to form context (ingress).
src/pages/network-policies/create-edit/NetworkPoliciesEgressCreateEditPage.tsx	Fetches team netpols to supply existing names to form context (egress).
src/pages/network-policies/create-edit/create-edit-networkPolicies.validator.ts	Adds uniqueness validation to network policy rule name.
src/pages/code-repositories/create-edit/create-edit-codeRepositories.validator.ts	Adds uniqueness validation to code repository name.
src/pages/code-repositories/create-edit/create-edit-codeRepositories.validator.test.ts	Adds tests for code repository name uniqueness behavior.
src/pages/code-repositories/create-edit/CodeRepositoriesCreateEditPage.tsx	Supplies existing code-repo names in form context.
src/pages/catalogs/platform/create-edit/create-edit-catalog.validator.ts	Adds uniqueness validation to catalog name.
src/pages/catalogs/platform/create-edit/create-edit-catalog.validator.test.ts	New tests covering catalog name uniqueness behavior.
src/pages/catalogs/platform/create-edit/CatalogsCreateEditPage.tsx	Fetches catalogs and supplies existing names to form context.
src/pages/builds/create-edit/create-edit-builds.validator.test.ts	New/expanded test coverage for build schema validation.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.

Suppressed comments (10)

src/pages/workloads/create-edit/WorkloadsCreateEditPage.tsx:106

• isLoadingTeamWorkloads is destructured from useGetTeamAplWorkloadsQuery but never used in this file, which will trigger unused-var linting and adds noise.

  const { data: teamWorkloads, isLoading: isLoadingTeamWorkloads } = useGetTeamAplWorkloadsQuery(
    { teamId },
    { skip: !teamId },
  )

src/pages/teams/create-edit/TeamsCreateEditPage.tsx:60

• isLoadingTeams, isFetchingTeams, and isErrorTeams are destructured from useGetAplTeamsQuery() but not used, which is likely to fail unused-var linting.

    data: teams,
    isLoading: isLoadingTeams,
    isFetching: isFetchingTeams,
    isError: isErrorTeams,
  } = useGetAplTeamsQuery()

src/pages/services/create-edit/ServicesCreateEditPage.tsx:117

• isLoadingTeamServices, isFetchingTeamServices, and refetchTeamServices are destructured from useGetTeamAplServicesQuery but never used in this file.

    data: teamServices,
    isLoading: isLoadingTeamServices,
    isFetching: isFetchingTeamServices,
    refetch: refetchTeamServices,
  } = useGetTeamAplServicesQuery({ teamId }, { skip: !teamId })

src/pages/secrets/team/create-edit/SecretCreateEditPage.tsx:103

• isLoadingTeamSealedSecrets, isFetchingTeamSealedSecrets, isErrorTeamSealedSecrets, and refetchTeamSealedSecrets are destructured from useGetAplSealedSecretsQuery but never used in this file.

    data: teamSealedSecrets,
    isLoading: isLoadingTeamSealedSecrets,
    isFetching: isFetchingTeamSealedSecrets,
    isError: isErrorTeamSealedSecrets,
    refetch: refetchTeamSealedSecrets,

src/pages/network-policies/create-edit/NetworkPoliciesIngressCreateEditPage.tsx:89

• isLoadingTeamNetworkPolicies is destructured from useGetTeamAplNetpolsQuery but not used.

  const { data: teamNetworkPolicies, isLoading: isLoadingTeamNetworkPolicies } = useGetTeamAplNetpolsQuery(
    { teamId },
    { skip: !teamId },
  )

src/pages/network-policies/create-edit/NetworkPoliciesEgressCreateEditPage.tsx:50

• isLoadingTeamNetworkPolicies is destructured from useGetTeamAplNetpolsQuery but not used.

  const { data: teamNetworkPolicies, isLoading: isLoadingTeamNetworkPolicies } = useGetTeamAplNetpolsQuery(
    { teamId },
    { skip: !teamId },
  )

src/pages/services/create-edit/ServicesCreateEditPage.tsx:144

• validateOnSubmit is set to !serviceName, which disables the new duplicate-name validation in edit flows. In this page, the service name can still be changed (admin text field or non-admin autocomplete), so duplicates can slip through when editing.

      domainSuffix: cluster.domainSuffix,
      existingNames,
      currentName: data?.metadata?.name,
      validateOnSubmit: !serviceName,
    },

src/pages/secrets/team/create-edit/create-edit-secrets.validator.ts:25

• Error message capitalization is inconsistent with the field label and other validators ("Secret Name" vs "Secret name"). This looks user-facing and should be sentence-cased for consistency.

      .test(uniqueNameTest('Secret Name already exists.')),

src/pages/code-repositories/create-edit/create-edit-codeRepositories.validator.ts:59

• Error message casing is inconsistent with the rest of the validator messages ("Code Repository Name" vs "Code repository name"). This appears user-facing and should use consistent sentence case.

      .test(uniqueNameTest('Code Repository Name already exists.')),

src/utils/uniqueName.validator.ts:1

• The file header comment points to validators/uniqueName.validator.ts, but the file lives in src/utils. This is misleading when navigating/searching.

// validators/uniqueName.validator.ts

[CasLubbers]

Validated on cluster and is working.
For consistency you could also add the uniqueNameTest() function to create-edit-builds. In there is now a custom function to test if its unique.

[Copilot]

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.

Suppressed comments (10)

src/utils/uniqueName.validator.ts:1

• The file header comment references a different path ("validators/...") than the actual location under src/utils, which can be misleading when navigating/searching.

// validators/uniqueName.validator.ts

src/pages/workloads/create-edit/WorkloadsCreateEditPage.tsx:106

• isLoadingTeamWorkloads is declared but never used, which can fail builds when noUnusedLocals/lint rules are enabled. Remove the unused binding.

  const { data: teamWorkloads, isLoading: isLoadingTeamWorkloads } = useGetTeamAplWorkloadsQuery(
    { teamId },
    { skip: !teamId },
  )

src/pages/teams/create-edit/TeamsCreateEditPage.tsx:60

• isLoadingTeams, isFetchingTeams, and isErrorTeams are declared but never used, which can fail builds when noUnusedLocals/lint rules are enabled. Remove the unused bindings.

  const {
    data: teams,
    isLoading: isLoadingTeams,
    isFetching: isFetchingTeams,
    isError: isErrorTeams,
  } = useGetAplTeamsQuery()

src/pages/services/create-edit/ServicesCreateEditPage.tsx:117

• isLoadingTeamServices, isFetchingTeamServices, and refetchTeamServices are declared but never used, which can fail builds when noUnusedLocals/lint rules are enabled. Remove the unused bindings (or use them).

  const {
    data: teamServices,
    isLoading: isLoadingTeamServices,
    isFetching: isFetchingTeamServices,
    refetch: refetchTeamServices,
  } = useGetTeamAplServicesQuery({ teamId }, { skip: !teamId })

src/pages/services/create-edit/ServicesCreateEditPage.tsx:144

• validateOnSubmit is set to !serviceName, which disables the duplicate-name check in edit mode. Since the Service Name field is still editable when serviceName is present, this can allow submitting a duplicate service name. Either disable renaming in edit mode, or keep validateOnSubmit enabled and rely on currentName to allow the unchanged value.

    context: {
      domainSuffix: cluster.domainSuffix,
      existingNames,
      currentName: data?.metadata?.name,
      validateOnSubmit: !serviceName,
    },

src/pages/secrets/team/create-edit/SecretCreateEditPage.tsx:104

• isLoadingTeamSealedSecrets, isFetchingTeamSealedSecrets, isErrorTeamSealedSecrets, and refetchTeamSealedSecrets are declared but never used, which can fail builds when noUnusedLocals/lint rules are enabled. Remove the unused bindings (or use them).

  const {
    data: teamSealedSecrets,
    isLoading: isLoadingTeamSealedSecrets,
    isFetching: isFetchingTeamSealedSecrets,
    isError: isErrorTeamSealedSecrets,
    refetch: refetchTeamSealedSecrets,
  } = useGetAplSealedSecretsQuery({ teamId }, { skip: !teamId })

src/pages/network-policies/create-edit/NetworkPoliciesIngressCreateEditPage.tsx:89

• isLoadingTeamNetworkPolicies is declared but never used, which can fail builds when noUnusedLocals/lint rules are enabled. Remove the unused binding (or use it).

  const { data: teamNetworkPolicies, isLoading: isLoadingTeamNetworkPolicies } = useGetTeamAplNetpolsQuery(
    { teamId },
    { skip: !teamId },
  )

src/pages/network-policies/create-edit/NetworkPoliciesEgressCreateEditPage.tsx:50

• isLoadingTeamNetworkPolicies is declared but never used, which can fail builds when noUnusedLocals/lint rules are enabled. Remove the unused binding (or use it).

  const { data: teamNetworkPolicies, isLoading: isLoadingTeamNetworkPolicies } = useGetTeamAplNetpolsQuery(
    { teamId },
    { skip: !teamId },
  )

src/utils/uniqueName.validator.test.ts:62

• The unit tests cover duplicate detection and casing/whitespace normalization, but they don’t cover the edit/rename scenario where currentName should be excluded from the duplicate check. Adding a test for currentName will protect the intended behavior in uniqueNameTest.

  it('skips validation when validateOnSubmit is false', async () => {
    await expect(
      schema.validate('repo-name', {
        context: {
          validateOnSubmit: false,
          existingNames: ['repo-name'],
        },
      }),
    ).resolves.toBe('repo-name')
  })
})

src/pages/services/create-edit/ServicesCreateEditPage.tsx:125

• existingNames is a new array on every render; since it’s a dependency of the filteredK8Services useMemo, that memo will recompute every render anyway. Memoizing existingNames by teamServices makes the filteredK8Services memoization effective.

  const existingNames = (teamServices ?? [])
    .map((item) => item?.metadata?.name)
    .filter((name): name is string => Boolean(name))

[Copilot]

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.

Suppressed comments (10)

src/pages/workloads/create-edit/WorkloadsCreateEditPage.tsx:106

• isLoadingTeamWorkloads is destructured from useGetTeamAplWorkloadsQuery but never used. With noUnusedLocals / ESLint enabled, this will fail the build/lint and is also misleading since the loading state isn’t incorporated anywhere.

  const { data: teamWorkloads, isLoading: isLoadingTeamWorkloads } = useGetTeamAplWorkloadsQuery(
    { teamId },
    { skip: !teamId },
  )

src/pages/teams/create-edit/TeamsCreateEditPage.tsx:60

• isLoadingTeams, isFetchingTeams, and isErrorTeams are destructured from useGetAplTeamsQuery() but never used. This typically triggers TypeScript/ESLint unused-variable failures.

  const {
    data: teams,
    isLoading: isLoadingTeams,
    isFetching: isFetchingTeams,
    isError: isErrorTeams,
  } = useGetAplTeamsQuery()

src/pages/services/create-edit/ServicesCreateEditPage.tsx:117

• isLoadingTeamServices, isFetchingTeamServices, and refetchTeamServices are destructured from useGetTeamAplServicesQuery but never used. This will trip unused-variable checks and currently the query state isn’t reflected in the page’s loading/refetch logic.

  const {
    data: teamServices,
    isLoading: isLoadingTeamServices,
    isFetching: isFetchingTeamServices,
    refetch: refetchTeamServices,
  } = useGetTeamAplServicesQuery({ teamId }, { skip: !teamId })

src/pages/secrets/team/create-edit/SecretCreateEditPage.tsx:104

• isLoadingTeamSealedSecrets, isFetchingTeamSealedSecrets, isErrorTeamSealedSecrets, and refetchTeamSealedSecrets are destructured from useGetAplSealedSecretsQuery but never used. This is likely to fail unused-variable checks.

  const {
    data: teamSealedSecrets,
    isLoading: isLoadingTeamSealedSecrets,
    isFetching: isFetchingTeamSealedSecrets,
    isError: isErrorTeamSealedSecrets,
    refetch: refetchTeamSealedSecrets,
  } = useGetAplSealedSecretsQuery({ teamId }, { skip: !teamId })

src/pages/network-policies/create-edit/NetworkPoliciesIngressCreateEditPage.tsx:89

• isLoadingTeamNetworkPolicies is destructured from useGetTeamAplNetpolsQuery but never used. This can fail unused-variable linting/TS checks.

  const { data: teamNetworkPolicies, isLoading: isLoadingTeamNetworkPolicies } = useGetTeamAplNetpolsQuery(
    { teamId },
    { skip: !teamId },
  )

src/pages/network-policies/create-edit/NetworkPoliciesEgressCreateEditPage.tsx:50

• isLoadingTeamNetworkPolicies is destructured from useGetTeamAplNetpolsQuery but never used. This is likely to trip unused-variable checks.

  const { data: teamNetworkPolicies, isLoading: isLoadingTeamNetworkPolicies } = useGetTeamAplNetpolsQuery(
    { teamId },
    { skip: !teamId },
  )

src/utils/uniqueName.validator.ts:1

• The file header comment points to validators/uniqueName.validator.ts, but the actual path is src/utils/uniqueName.validator.ts. This can be confusing when searching or moving code.

// validators/uniqueName.validator.ts

src/pages/secrets/team/create-edit/create-edit-secrets.validator.ts:25

• The new duplicate-name error message uses inconsistent capitalization (Secret Name...) compared to the other messages in this schema (sentence case). Aligning it improves consistency and readability.

      .test(uniqueNameTest('Secret Name already exists.')),

src/pages/code-repositories/create-edit/create-edit-codeRepositories.validator.ts:59

• The new duplicate-name error message uses title casing (Code Repository Name...) while the rest of the validator uses sentence case (e.g., Code repository name ...). Consider standardizing the casing, and update the associated tests to match the chosen message.

      .test(uniqueNameTest('Code Repository Name already exists.')),

src/utils/uniqueName.validator.test.ts:61

• The new helper supports currentName (to allow keeping the existing name during edits), but there isn’t a unit test covering that branch. Adding a test for the currentName exception helps prevent regressions in edit flows.

  it('skips validation when validateOnSubmit is false', async () => {
    await expect(
      schema.validate('repo-name', {
        context: {
          validateOnSubmit: false,

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Copilot]

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.

Suppressed comments (9)

src/pages/workloads/create-edit/WorkloadsCreateEditPage.tsx:103

• isLoadingTeamWorkloads is declared but never used, which will either fail lint/TS noUnusedLocals checks or leave dead code behind. If you don't need the loading state, destructure only data; otherwise, incorporate the loading flag into the page's loading/submit gating.

  const { data: teamWorkloads, isLoading: isLoadingTeamWorkloads } = useGetTeamAplWorkloadsQuery(

src/pages/teams/create-edit/TeamsCreateEditPage.tsx:60

• isLoadingTeams, isFetchingTeams, and isErrorTeams are destructured but never used. This is dead code and may trigger unused-variable checks.

    data: teams,
    isLoading: isLoadingTeams,
    isFetching: isFetchingTeams,
    isError: isErrorTeams,
  } = useGetAplTeamsQuery()

src/pages/services/create-edit/ServicesCreateEditPage.tsx:117

• isLoadingTeamServices, isFetchingTeamServices, and refetchTeamServices are destructured but never used. Remove them or use them to gate UI/validation so the additional query isn’t just adding dead code.

    data: teamServices,
    isLoading: isLoadingTeamServices,
    isFetching: isFetchingTeamServices,
    refetch: refetchTeamServices,
  } = useGetTeamAplServicesQuery({ teamId }, { skip: !teamId })

src/pages/services/create-edit/ServicesCreateEditPage.tsx:144

• In edit mode (serviceName is truthy), the service name field is still editable, but validateOnSubmit is set to false, which disables the duplicate-name validation entirely. This allows renaming to an existing service name without any client-side validation.

    context: {
      domainSuffix: cluster.domainSuffix,
      existingNames,
      currentName: data?.metadata?.name,
      validateOnSubmit: !serviceName,
    },

src/pages/secrets/team/create-edit/SecretCreateEditPage.tsx:103

• isLoadingTeamSealedSecrets, isFetchingTeamSealedSecrets, isErrorTeamSealedSecrets, and refetchTeamSealedSecrets are destructured but never used, which leaves dead code (and may violate unused-variable rules).

    data: teamSealedSecrets,
    isLoading: isLoadingTeamSealedSecrets,
    isFetching: isFetchingTeamSealedSecrets,
    isError: isErrorTeamSealedSecrets,
    refetch: refetchTeamSealedSecrets,

src/pages/network-policies/create-edit/NetworkPoliciesIngressCreateEditPage.tsx:89

• isLoadingTeamNetworkPolicies is destructured but never used. Either remove it or use it to gate validation/UI so the uniqueness list is ready before submit.

  const { data: teamNetworkPolicies, isLoading: isLoadingTeamNetworkPolicies } = useGetTeamAplNetpolsQuery(
    { teamId },
    { skip: !teamId },
  )

src/pages/network-policies/create-edit/NetworkPoliciesEgressCreateEditPage.tsx:50

• isLoadingTeamNetworkPolicies is destructured but never used. This is dead code and may trigger unused-variable checks.

  const { data: teamNetworkPolicies, isLoading: isLoadingTeamNetworkPolicies } = useGetTeamAplNetpolsQuery(
    { teamId },
    { skip: !teamId },
  )

src/utils/uniqueName.validator.ts:1

• The header comment references validators/uniqueName.validator.ts, but this file lives under src/utils. This is misleading when navigating/searching the codebase.

// validators/uniqueName.validator.ts

src/utils/uniqueName.validator.test.ts:62

• The uniqueNameTest behavior for currentName (allowing the current resource name during edit) isn’t covered by tests. Adding a test for this prevents regressions in the duplicate-name logic.

  it('skips validation when validateOnSubmit is false', async () => {
    await expect(
      schema.validate('repo-name', {
        context: {
          validateOnSubmit: false,
          existingNames: ['repo-name'],
        },
      }),
    ).resolves.toBe('repo-name')
  })
})