handle the domain in password manager#69
Open
voostar wants to merge 1 commit intolinkedin:masterfrom
voostar:master
Open
handle the domain in password manager#69voostar wants to merge 1 commit intolinkedin:masterfrom voostar:master
voostar wants to merge 1 commit intolinkedin:masterfrom
voostar:master
Conversation
… no set from username.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If username not within domain name, password manager will set the domain name to "." (dot). In my case, the dot is not accept by the exchange server.
The two new line codes are going to set domain to null if password manager can't analyze the domain from username to avoid use dot instead