Move test sources to androidTest so they are discoverable#209
Open
jselbo wants to merge 1 commit intolinkedin:mainfrom
Open
Move test sources to androidTest so they are discoverable#209jselbo wants to merge 1 commit intolinkedin:mainfrom
jselbo wants to merge 1 commit intolinkedin:mainfrom
Conversation
The test classes in dexmaker-mockito-inline-tests and dexmaker-mockito-inline-extended-tests were in src/main/java, making them compile as library code rather than instrumentation tests. This was done in 8524de2 to allow cross-module inclusion via Gradle dependencies instead of symlinks, but left the tests unrunnable from Gradle's connectedDebugAndroidTest task. Move test sources to src/androidTest/java and update dependencies to androidTestImplementation so the test runner can discover them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the test sub-projects (except
dexmaker-tests) had sources in src/main/java, making them compile as library code rather than instrumentation tests. This was apparently done in 8524de2 intentionally, but as far as I can tell it left the tests unrunnable fromconnectedAndroidTesttask.Move test sources to
src/androidTest/javaand update dependencies to androidTestImplementation so the test runner can discover them.Before:
./gradlew connectedAndroidTestonly runs
dexmaker-teststestsAfter: