[Coral-Trino] Modify transformation for CURRENT_TIMESTAMP#483
Open
ljfgem wants to merge 1 commit intolinkedin:masterfrom
Open
[Coral-Trino] Modify transformation for CURRENT_TIMESTAMP#483ljfgem wants to merge 1 commit intolinkedin:masterfrom
ljfgem wants to merge 1 commit intolinkedin:masterfrom
Conversation
Contributor
|
Could you evaluate the Spark behavior in case Spark is used on the LHS? What triggered this issue? Is it still required? FYI @phd3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request, and why are they necessary?
In Hive,
CURRENT_TIMESTAMPreturns aUTCtimestamp, whereas in Trino, it returns a timestamp based on the session's timezone. Therefore, to be compatible with Hive query result,AT TIME ZONE 'UTC'should be added to the translated Trino SQL. For example,SELECT CURRENT_TIMESTAMPis transformed intoSELECT CAST(CURRENT_TIMESTAMP AT TIME ZONE 'UTC' AS TIMESTAMP(3)).How was this patch tested?
Modified unit tests.