Fix half-pixel offset when sampling images using pixel centers not corners#1499
Open
Keavon wants to merge 1 commit intolinebender:mainfrom
Open
Fix half-pixel offset when sampling images using pixel centers not corners#1499Keavon wants to merge 1 commit intolinebender:mainfrom
Keavon wants to merge 1 commit intolinebender:mainfrom
Conversation
This was referenced Mar 11, 2026
Member
|
I believe that this change is correct - thanks! I'm slightly surprised that this does not fix any of the known_issues tests, nor indeed changes any of the other snapshots? I would quite like this to have some test coverage. I think that this should also have a changelog entry, but I won't block on you adding that. |
Author
|
Is the changelog entry something you could add, if you don't mind? I'm not very familiar with your development processes for doing that effectively. (I assume we're just talking about writing a sentence for that, presumably using a certain style that matches the others in the same phrasing.) |
Member
|
Yeah, as I noted the changelog entry isn't blocking. This PR is currently blocked on CI though, and (possibly relatedly) test coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #972 in Vello and GraphiteEditor/Graphite#3018 in Graphite.
Here are some screenshots (view them at exactly 100% scale) from the Graphite viewport.
Blurry (currently in Vello):
Pixel-perfect (this fix):
Ground truth pixel-perfect (Graphite's SVG renderer, not Vello):
Disclosure: this is discovered and fixed with the help of Claude Code, but tested in Graphite. I have not, however, tested this in isolation outside of Graphite, but that might be something a reviewer could help with.