Updated model with current best practices, added getting started notebook#5
Updated model with current best practices, added getting started notebook#5
Conversation
…ted a getting started notebook that uses the model.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
============================================
- Coverage 100.00% 26.08% -73.92%
============================================
Files 2 2
Lines 6 69 +63
============================================
+ Hits 6 18 +12
- Misses 0 51 +51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the external Hyrax example package to showcase a more realistic CNN model (VGG11) and adds a pre-executed “getting started” notebook demonstrating training/inference on HyraxCifar data.
Changes:
- Added a
VGG11PyTorch model registered via@hyrax_model, including train/validate/test/infer batch hooks. - Updated the package default config and public exports to use
VGG11instead of the removedExampleModel. - Added a pre-executed notebook documenting end-to-end usage, and updated
.gitignorefor generated outputs/data.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
src/external_hyrax_example/models/vgg11.py |
New VGG11 model implementation + Hyrax loop hooks and data preparation. |
src/external_hyrax_example/example_model.py |
Removed the prior minimal example model. |
src/external_hyrax_example/default_config.toml |
Switched default configuration structure to external_hyrax_example.VGG11.*. |
src/external_hyrax_example/__init__.py |
Export VGG11 as the package public model. |
pyproject.toml |
Added hyrax and torch dependencies. |
docs/pre_executed/model_usage_example.ipynb |
Added a pre-executed notebook showing how to configure/train/infer/evaluate. |
.gitignore |
Ignored Hyrax results directories and local data/. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updating the example model to show current Hyrax best practices.
Implemented a VGG11 model.
Created a getting started notebook that uses the VGG11 model and trains on HyraxCifar data - results in 70% accuracy.