Skip to content

chore(federated-identity-service): pass biome lint#375

Open
rezk2ll wants to merge 1 commit into
devfrom
chore/federated-identity-biome-pass
Open

chore(federated-identity-service): pass biome lint#375
rezk2ll wants to merge 1 commit into
devfrom
chore/federated-identity-biome-pass

Conversation

@rezk2ll
Copy link
Copy Markdown
Member

@rezk2ll rezk2ll commented May 26, 2026

Summary

Replaces x != null / x == null nullish checks with x !== undefined && x !== null (and the == variant) to satisfy noDoubleEquals with ignoreNull: false; converts for (const i in [...Array(101).keys()]) rate-limit test loops to plain numeric for loops with typed let bindings; wraps single-expression .forEach((x) => set.add(x)) callbacks in braces so useIterableCallbackReturn no longer fires; swaps as any[] for as unknown[] in the validation middleware; drops unused imports and dead variables; adds a biome-ignore for the example script's intentional console.log. Most of the diff is the formatter's single-to-double-quote and import-reorganisation pass.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026

Warning

Review limit reached

@rezk2ll, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 2 minutes and 52 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7ecfc7ff-93f0-4d14-bb7f-74f30c140550

📥 Commits

Reviewing files that changed from the base of the PR and between 93e11b7 and 9ba3361.

📒 Files selected for processing (15)
  • packages/federated-identity-service/example/federated-identity-service.ts
  • packages/federated-identity-service/jest.config.js
  • packages/federated-identity-service/jest.globals.ts
  • packages/federated-identity-service/rollup.config.js
  • packages/federated-identity-service/src/__testData__/build-userdb.ts
  • packages/federated-identity-service/src/controllers/controllers.ts
  • packages/federated-identity-service/src/index.test.ts
  • packages/federated-identity-service/src/index.ts
  • packages/federated-identity-service/src/middlewares/auth.ts
  • packages/federated-identity-service/src/middlewares/errors.ts
  • packages/federated-identity-service/src/middlewares/utils.ts
  • packages/federated-identity-service/src/middlewares/validation.ts
  • packages/federated-identity-service/src/routes/routes.ts
  • packages/federated-identity-service/src/types.ts
  • packages/federated-identity-service/src/utils/ip-address.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 26, 2026

View your CI Pipeline Execution ↗ for commit 9ba3361

Command Status Duration Result
nx affected -t test ✅ Succeeded 1m 54s View ↗
nx affected -t build ✅ Succeeded 8s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-26 18:26:03 UTC

@rezk2ll rezk2ll requested a review from pm-McFly May 26, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant