Skip to content

feat: show dependencies of resource#985

Open
mburri wants to merge 6 commits intomasterfrom
feat/analyze-show-dependencies
Open

feat: show dependencies of resource#985
mburri wants to merge 6 commits intomasterfrom
feat/analyze-show-dependencies

Conversation

@mburri
Copy link
Copy Markdown
Member

@mburri mburri commented Mar 30, 2026

This PR adds the functionality to show dependencies of a resource.

notable points are:

  • show dependencies is always shown - there is no restriction on resource type or permissions.
  • there were no permission checks whatsoever to show dependencies (in the backend). It's available for all authenticated users.
  • the table contains an action button to edit the dependency. The context parameter is hard coded to ctx=1 - this was already the case for the old implmentation

I decided to rework the page layout after implementing the navigation items - and clean it up over all pages. Now all pages are different.

import ch.mobi.itc.mobiliar.rest.resources.*;
import ch.mobi.itc.mobiliar.rest.resources.dependencies.ResourceDependenciesRest;
import ch.mobi.itc.mobiliar.rest.resources.resourceTags.ResourceTagsRest;
import ch.mobi.itc.mobiliar.rest.resources.PropertyDescriptorRest;
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a duplicated import, since ch.mobi.itc.mobiliar.rest.resources.* already imports this (see line 34)

@mburri mburri requested a review from StephGit March 30, 2026 14:51
<h2>{{ title }}</h2>
</div>
<div class="card-body p-0">
<table class="table table-sm">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the existing table.component

<td>{{ dependency.resourceName }}</td>
<td>{{ dependency.releaseName }}</td>
<td>
<a
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the button component / edit icon instead of text

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty file

Copy link
Copy Markdown
Contributor

@StephGit StephGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feature is missing for resource-type.edit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants