fix(plugin-id/ui): keep dropdown list intact after value selection#26
Merged
Merged
Conversation
…Company edit When the user picks a scope, Vuetify echoes the selected name back through @update:search; the local filter then narrows the dropdown to just that one item, and re-opening the dropdown shows only the already-selected scope, blocking the user from switching to another one. Treat the case where the query equals the currently selected name as "no filter" so the full list stays visible on re-open.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Vuetify v-autocomplete dropdown filter that was incorrectly
reducing the list to a single item after selection on edit views,
making it impossible to change the value later.
Cause
When the user picks a value, Vuetify re-emits the selected value's
name through
@update:search. Our local filter (used because thescope dataset is small and preloaded) interpreted this as a new search
query and reduced the list to just the selected item.
Fix
Ignore the @update:search event if the query matches the currently-
selected value. Tiny patch on filterScopes().
Files