feat(plugin-id): show Groups field on user creation with preloaded dropdown#23
Merged
Merged
Conversation
Per Fabrice's review (18 mai 13:30): the Groups multi-select autosuggest was previously hidden on /id/user/new with a v-if="isEdit". Removing the guard so the field is visible on both create and edit modes. The save() payload is updated to send the groups array in both cases. On /new only, the dropdown is preloaded with the first 20 groups and opened on mount so the available groups are visible without typing. /edit keeps the existing behaviour (the user's existing groups are already shown as chips).
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the Groups multi-select autosuggest visible on user creation, not
only on edit (per Fabrice's review of 18 mai 13:30).
Main change
Remove
v-if="isEdit"from the Groups v-autocomplete block so the fieldis shown on both /id/user/new and /id/user/:id. The save() payload is
updated to send the
groupsarray in both create and edit modes.Bonus UX
While touching the Groups field, also preload the first 20 groups via
rest/service/id/group?rows=20at mount and open the dropdown so theuser can browse without having to type. This addresses an adjacent
review point ("le dropdown des groupes devrait afficher une liste
filtrée même si l'utilisateur n'a pas saisi de caractères").
Tested
groups, autosuggest filters on keystroke, chips selectable