Skip to content

LCORE-1872: pass OKP/Solr environment variables to llama-stack container#1807

Open
anik120 wants to merge 1 commit into
lightspeed-core:mainfrom
anik120:env-var-to-container
Open

LCORE-1872: pass OKP/Solr environment variables to llama-stack container#1807
anik120 wants to merge 1 commit into
lightspeed-core:mainfrom
anik120:env-var-to-container

Conversation

@anik120
Copy link
Copy Markdown
Contributor

@anik120 anik120 commented May 27, 2026

Description

Fixes: llama_stack.core.stack.EnvVarError when using OKP RAG with make run

Added environment variable pass-through for OKP/Solr configuration:

  • RH_SERVER_OKP (required) - OKP server URL
  • SOLR_URL, SOLR_COLLECTION, SOLR_VECTOR_FIELD, etc. (optional)

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: (e.g., Claude, CodeRabbit, Ollama, etc., N/A if not used)
  • Generated by: (e.g., tool name and version; N/A if not used)

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Fixes: llama_stack.core.stack.EnvVarError when using OKP RAG with make run

Added environment variable pass-through for OKP/Solr configuration:
- RH_SERVER_OKP (required) - OKP server URL
- SOLR_URL, SOLR_COLLECTION, SOLR_VECTOR_FIELD, etc. (optional)

Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Warning

Review limit reached

@anik120, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 50 minutes and 42 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2a221f7d-3da1-4ee8-8d5b-41b77ef9a430

📥 Commits

Reviewing files that changed from the base of the PR and between 397acf1 and b1ce96f.

📒 Files selected for processing (2)
  • Makefile
  • docker-compose.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant