LCORE-2308: LlamaStack Pydantic AI Provider#1806
Draft
jrobertboos wants to merge 3 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| path: str, | ||
| body: dict[str, Any], | ||
| ) -> httpx.Response: | ||
| assert self._client.route_impls is not None |
Comment on lines
+82
to
+83
| lib_http_client = httpx.AsyncClient( | ||
| transport=transport, base_url="http://llama-stack-library" |
Comment on lines
+72
to
+73
| assert ( | ||
| base_url is None |
| assert ( | ||
| base_url is None | ||
| ), "Cannot provide both `library_client` and `base_url`" | ||
| assert api_key is None, "Cannot provide both `library_client` and `api_key`" |
Comment on lines
+76
to
+77
| assert ( | ||
| http_client is None |
| path: str, | ||
| body: dict[str, Any], | ||
| ) -> httpx.Response: | ||
| assert self._client.route_impls is not None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing