ci: add claude PR review workflow using differential-review skill#10654
ci: add claude PR review workflow using differential-review skill#10654ziggie1984 wants to merge 1 commit intolightningnetwork:masterfrom
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
e97a95f to
2c807c0
Compare
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| pull-requests: write |
There was a problem hiding this comment.
Clarification: Does Claude need 'write' permission to post review comments on the issue or pr?
There was a problem hiding this comment.
yes because we want to post comments on the PR
883f5c6 to
86e3a2a
Compare
|
@ziggie1984, remember to re-request review from reviewers when ready |
f8d20b7 to
a5eff49
Compare
New CI: Claude PR Review WorkflowThis PR adds a new Why a separate workflow?The existing This new workflow works around that by using How it is triggeredThe workflow activates on any of the following:
It then runs our own |
|
@claude are you being able to fetch the fork branch? Also review this change to check. |
|
I'll analyze this and get back to you. |
Wire up the claude-review workflow to invoke our own /code-review slash command via claude -p, posting the findings as a PR comment.
a5eff49 to
96a81fd
Compare
|
After looking into the security implications of running the Claude workflow in CI, we've identified a few concerns worth noting: The current setup checks out untrusted fork code in the same job that holds the CLAUDE_CODE_OAUTH_TOKEN. This creates a potential attack vector where a malicious PR could include Possible mitigations include adding an author_association guard, a precheck on modified Claude config files, or a full split-job architecture — but each comes with its own tradeoffs. For now we have decided to run Claude reviews locally rather than through CI. This avoids the problem entirely — no secrets are exposed, no untrusted code runs in a shared environment, |

Summary
claude-review.ymlworkflow triggered by@claude reviewcomments on PRsdifferential-reviewskill from lightninglabs/agent-skills, cloned at runtime@v1fails withfatal: couldn't find remote refon fork branches)@claude reviewfromclaude.ymlto prevent both workflows firing on the same commentworkflow_dispatchfor testing the workflow on this branch before mergingTest plan
@claude reviewon a fork PR and confirm it doesn't hit the branch fetch errorworkflow_dispatchblock before final merge