Bump lnd to latest v0.21.x branch commit#275
Open
ziggie1984 wants to merge 2 commits into
Open
Conversation
ziggie1984
force-pushed
the
bump-lnd-v0.21.0-rc1
branch
from
d6940ee to
ba9a866
Compare
ziggie1984
changed the title
Use lnd commit 1dc2a4f321cc7ba864aff4a692297bbfbbceddf6 from the v0.21.x branch instead of the v0.21.0-beta.rc1 tag so lndclient tracks the latest branch state. Align the kvdb, queue, and sqldb split modules to the same lnd commit.
Use routerrpc.SendPaymentV2 because the legacy SendPaymentSync RPC is no longer available in the lnd v0.21.x dependency. Track already completed payments with TrackPaymentV2 so PayInvoice returns the stored fee, amount, and preimage instead of assuming a zero fee.
ziggie1984
force-pushed
the
bump-lnd-v0.21.0-rc1
branch
from
ba9a866 to
a7de1f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1dc2a4f321cc7ba864aff4a692297bbfbbceddf6Router RPC tradeoff
PayInvoice remains on the existing LightningClient API, but it now internally uses the router RPC client. This avoids a public API move to RouterClient while matching the supported lnd v0.21.x payment RPC surface. The tradeoff is that PayInvoice now depends on the router subserver and router macaroon in addition to the normal Lightning client wiring.
Verification