Skip to content

routerclient: add EstimateRouteFeeWithRequest and deprecate EstimateRouteFee#273

Open
hieblmi wants to merge 1 commit into
lightninglabs:masterfrom
hieblmi:upgrade-estimate-route-fee
Open

routerclient: add EstimateRouteFeeWithRequest and deprecate EstimateRouteFee#273
hieblmi wants to merge 1 commit into
lightninglabs:masterfrom
hieblmi:upgrade-estimate-route-fee

Conversation

@hieblmi
Copy link
Copy Markdown
Contributor

@hieblmi hieblmi commented May 4, 2026

  • Add EstimateRouteFeeWithRequest to expose the full current LND EstimateRouteFee request surface:
    • graph-based estimates via Dest + Amount
    • payment-request probing via PaymentRequest
    • probe timeout via Timeout
  • Add EstimateRouteFeeResponse so callers can access RoutingFee, TimeLockDelay, and FailureReason.
  • Keep the existing EstimateRouteFee(ctx, dest, amt) method as a deprecated compatibility wrapper.
  • Update macaroon recipe method mapping so the new wrapper maps to the existing /routerrpc.Router/EstimateRouteFee permission.
  • Add unit tests for graph estimates, invoice probe estimates, legacy delegation, and timeout validation.

@hieblmi hieblmi requested a review from starius May 4, 2026 08:57
@lightninglabs-deploy
Copy link
Copy Markdown

@starius: review reminder

@starius
Copy link
Copy Markdown
Contributor

starius commented May 18, 2026

EstimateRouteFeeWithRequest is oneof (old EstimateRouteFee , PaymentRequest + Timeout).

Wouldn't it be better to add another method for the PaymentRequest + Timeout variant and avoid EstimateRouteFee deprecation? Given the new method is split between these two variants anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants