PaginatedKVStore follow ups#4447
Merged
TheBlueMatt merged 2 commits intolightningdevkit:mainfrom Feb 26, 2026
Merged
Conversation
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
Previously, all fs::metadata errors were silently ignored via .ok(), which could hide permission or I/O errors. Now error are properly handled.
benthecarman
force-pushed
the
paginated-follow-ups
branch
from
a99b3fb to
0723ffd
Compare
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4447 +/- ##
==========================================
+ Coverage 85.94% 85.96% +0.02%
==========================================
Files 159 159
Lines 104644 104647 +3
Branches 104644 104647 +3
==========================================
+ Hits 89934 89958 +24
+ Misses 12204 12181 -23
- Partials 2506 2508 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, all
fs::metadataerrors were silently ignored via.ok(), which could hide permission or I/O errors. Now errors are properly handled.Also removes unnecessary clones that were done for constructing the page token