Skip to content

Conversation

@wpaulino
Copy link
Contributor

This includes a new seed that covers the splice flow to completion
(exchanging `splice_locked` and promoting the `FundingScope`).

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

@wpaulino wpaulino added this to the 0.3 milestone Jan 29, 2026
@wpaulino wpaulino requested a review from TheBlueMatt January 29, 2026 22:07
@wpaulino wpaulino self-assigned this Jan 29, 2026
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jan 29, 2026

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.08%. Comparing base (fcc3d33) to head (b52b069).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4361      +/-   ##
==========================================
- Coverage   86.09%   86.08%   -0.01%     
==========================================
  Files         156      156              
  Lines      102804   102804              
  Branches   102804   102804              
==========================================
- Hits        88508    88503       -5     
- Misses      11787    11794       +7     
+ Partials     2509     2507       -2     
Flag Coverage Δ
tests 86.08% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

TheBlueMatt
TheBlueMatt previously approved these changes Jan 30, 2026
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yea. Trivial (ignoring the stuff in 4336 that already landed).

@wpaulino wpaulino dismissed TheBlueMatt’s stale review January 30, 2026 00:52

The merge-base changed after approval.

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

TheBlueMatt
TheBlueMatt previously approved these changes Jan 30, 2026
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yea. Trivial (ignoring the stuff in 4336 that already landed).

@TheBlueMatt
Copy link
Collaborator

weird, github wont let me land this, i guess it does need rebase.

@wpaulino wpaulino dismissed TheBlueMatt’s stale review January 30, 2026 01:53

The merge-base changed after approval.

This includes a new seed that covers the splice flow to completion
(exchanging `splice_locked` and promoting the `FundingScope`).

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@TheBlueMatt TheBlueMatt merged commit f9ad345 into lightningdevkit:main Jan 30, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants