Split CI script into separate GitHub Actions steps #4357
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
joostjager
changed the title
ci/ci-tests.sh
Outdated
| } | ||
|
|
||
| # Initialize GitHub Actions Job Summary | ||
| if [ -n "$GITHUB_STEP_SUMMARY" ]; then |
There was a problem hiding this comment.
Given this is just nice printing should we always turn it on rather than only for CI?
There was a problem hiding this comment.
We can do that, but in which file would you want to save the output? The file is, during CI, in $GITHUB_STEP_SUMMARY
There was a problem hiding this comment.
Oh I just skimmed it and thought it printed didn't write to a file.
There was a problem hiding this comment.
Wasn't happy with the way github does the step summary. Now pushed a different approach that just splits up the workflow in more granular steps.
There was a problem hiding this comment.
Bleh, no, ci-tests.sh exists so that we're not tied to github and so that people can run it locally. Splitting it into a million bits breaks those existing goals.
There was a problem hiding this comment.
You can still run ci-tests.sh
joostjager
force-pushed
the
ci-test-summary
branch
from
13792ed to
03aa9f1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4357 +/- ##
==========================================
+ Coverage 86.08% 86.11% +0.03%
==========================================
Files 156 156
Lines 102428 102610 +182
Branches 102428 102610 +182
==========================================
+ Hits 88179 88367 +188
+ Misses 11754 11748 -6
Partials 2495 2495
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Not happy with this yet, exploring other options. |
This allows GitHub Actions to show individual test step progress in the UI, making it easier to identify which specific test phase failed without scrolling through logs. The ci-tests.sh script now accepts an optional step name argument. When provided, it runs only that step. When omitted, it runs all steps as before, preserving backward compatibility for local testing. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
joostjager
force-pushed
the
ci-test-summary
branch
from
4f74e2d to
6f524c7
Compare
joostjager
changed the title
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
I'm still not really sold on this - we're gonna end up missing a step that we add in CI or something and is more logic in ci-tests.sh really helpful - how often are you actually looking at individual steps to understand the performance profile of ci-tests.sh?
|
It's not so much about performance profile anymore. That was what I had initially. The current shape of it is to make it easy to see which test failed and jump to log files. It's friction that I experience with one big log file. Adding things in CI is not something that happens very often. I think it is worth doing this change. If you add to CI and follow the pattern, it seems unlikely that something is forgotten. |
3 participants
Summary
ci-tests.shto accept an optional step name argument, running only that step when providedbuild.yml./ci/ci-tests.shwithout arguments still executes all stepsMotivation
GitHub Actions UI now shows individual test step progress, making it easier to identify which specific test phase failed without scrolling through logs.