Skip to content

Defer ChainMonitor updates and persistence to flush (wrapper approach) #4345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joostjager wants to merge 1 commit into from

Add deferred ChainMonitor updates with batched persistence

bc5bfac
Select commit
Loading
Failed to load commit list.
Closed

Defer ChainMonitor updates and persistence to flush (wrapper approach) #4345

Add deferred ChainMonitor updates with batched persistence
bc5bfac
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 9, 2026 in 1s

86.01% (+0.00%) compared to 4800a47

View this Pull Request on Codecov

86.01% (+0.00%) compared to 4800a47

Details

Codecov Report

❌ Patch coverage is 86.73780% with 87 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.01%. Comparing base (4800a47) to head (bc5bfac).
⚠️ Report is 48 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/chain/deferred.rs 88.88% 60 Missing and 7 partials ⚠️
lightning-background-processor/src/lib.rs 68.75% 11 Missing and 4 partials ⚠️
lightning/src/chain/chainmonitor.rs 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #4345    +/-   ##
========================================
  Coverage   86.01%   86.01%            
========================================
  Files         156      157     +1     
  Lines      102781   103751   +970     
  Branches   102781   103751   +970     
========================================
+ Hits        88409    89245   +836     
- Misses      11864    11976   +112     
- Partials     2508     2530    +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov