Skip to content

Logging and spans via thread-local storage #4223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joostjager wants to merge 3 commits into from

Add log scope to send_payment

7dd7d6f
Select commit
Loading
Failed to load commit list.
Closed

Logging and spans via thread-local storage #4223

Add log scope to send_payment
7dd7d6f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 3, 2025 in 1s

89.34% (+0.00%) compared to de384ff

View this Pull Request on Codecov

89.34% (+0.00%) compared to de384ff

Details

Codecov Report

❌ Patch coverage is 84.96503% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.34%. Comparing base (de384ff) to head (7dd7d6f).

Files with missing lines Patch % Lines
lightning/src/chain/channelmonitor.rs 83.33% 23 Missing ⚠️
lightning/src/util/logger.rs 75.00% 3 Missing and 6 partials ⚠️
lightning-macros/src/lib.rs 73.07% 6 Missing and 1 partial ⚠️
lightning/src/chain/onchaintx.rs 91.11% 4 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4223   +/-   ##
=======================================
  Coverage   89.33%   89.34%           
=======================================
  Files         180      180           
  Lines      139042   139082   +40     
  Branches   139042   139082   +40     
=======================================
+ Hits       124219   124264   +45     
+ Misses      12196    12193    -3     
+ Partials     2627     2625    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov