Skip to content

Drop the need for fork headers when calling Listen's disconnect #3876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkczyz merged 5 commits into from
Sep 5, 2025

Add further additional documentation to `Listen`

a5b745a
Select commit
Loading
Failed to load commit list.
Merged

Drop the need for fork headers when calling Listen's disconnect #3876

Add further additional documentation to `Listen`
a5b745a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 2, 2025 in 1s

88.74% (+0.00%) compared to 86c6960

View this Pull Request on Codecov

88.74% (+0.00%) compared to 86c6960

Details

Codecov Report

❌ Patch coverage is 79.36508% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.74%. Comparing base (86c6960) to head (a5b745a).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/chain/channelmonitor.rs 70.00% 6 Missing ⚠️
lightning/src/chain/mod.rs 0.00% 5 Missing ⚠️
lightning/src/util/sweep.rs 0.00% 5 Missing ⚠️
lightning-liquidity/src/manager.rs 0.00% 4 Missing ⚠️
lightning-block-sync/src/test_utils.rs 66.66% 3 Missing ⚠️
lightning-block-sync/src/init.rs 90.00% 1 Missing ⚠️
lightning/src/ln/channelmanager.rs 95.83% 1 Missing ⚠️
lightning/src/ln/functional_tests.rs 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3876   +/-   ##
=======================================
  Coverage   88.73%   88.74%           
=======================================
  Files         176      176           
  Lines      129106   129102    -4     
  Branches   129106   129102    -4     
=======================================
+ Hits       114567   114575    +8     
+ Misses      11937    11931    -6     
+ Partials     2602     2596    -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov