Skip to content

Sweeper async change destination source fetching #3734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnull merged 3 commits into from
May 14, 2025

Convert sweeper to use an async ChangeDestinationSource and provide

1a98158
Select commit
Loading
Failed to load commit list.
Merged

Sweeper async change destination source fetching #3734

Convert sweeper to use an async ChangeDestinationSource and provide
1a98158
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 13, 2025 in 0s

90.61% (+1.47%) compared to f507778

View this Pull Request on Codecov

90.61% (+1.47%) compared to f507778

Details

Codecov Report

Attention: Patch coverage is 81.65939% with 42 lines in your changes missing coverage. Please review.

Project coverage is 90.61%. Comparing base (f507778) to head (1a98158).
Report is 64 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/util/sweep.rs 77.16% 25 Missing and 12 partials ⚠️
lightning/src/util/async_poll.rs 57.14% 3 Missing ⚠️
lightning-background-processor/src/lib.rs 96.22% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3734      +/-   ##
==========================================
+ Coverage   89.13%   90.61%   +1.47%     
==========================================
  Files         157      157              
  Lines      123851   134826   +10975     
  Branches   123851   134826   +10975     
==========================================
+ Hits       110395   122170   +11775     
+ Misses      10779    10016     -763     
+ Partials     2677     2640      -37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov