Run LDK initialization concurrently - #102
Merged
Merged
Conversation
TheBlueMatt
reviewed
Aug 19, 2026
| let logger = Arc::clone(&logger); | ||
| async move { | ||
| Ok::<_, InitFailure>(Arc::new( | ||
| LightningWallet::init(runtime, config, store, event_queue, tx_metadata, logger) |
Contributor
There was a problem hiding this comment.
Given LightningWallet::init is already async should the spawn not live there instead of here?
LDK initialization does not yield while it restores and starts the node, so Spark cannot progress inside the join. Use a separate task to allow both initializers to run concurrently.
benthecarman
force-pushed
the
review-issue-101
branch
from
August 19, 2026 19:48
a24be17 to
e6b9e64
Compare
TheBlueMatt
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #101
LDK initialization does not yield while it restores and starts the node, so Spark cannot progress inside the join. Use a separate task to allow both initializers to run concurrently.