Update ldk-node dependency & expose bolt12 proofs - #258
Open
benthecarman wants to merge 2 commits into
Open
Conversation
Adapt payment events to the updated ldk-node API and expose their payment IDs. Continue to handle unknown BOLT 11 payments manually so the receive-for-hash APIs work correctly.
Add payer-proof creation to the gRPC, CLI, and MCP interfaces. Include the preimage and invoice in successful-payment events because stateless proof creation requires both values. AI assistance: OpenAI Codex was used to rebase and verify this change.
|
I've assigned @wpaulino as a reviewer! |
benthecarman
marked this pull request as ready for review
August 18, 2026 05:28
tnull
reviewed
Aug 18, 2026
| /// | ||
| /// The claim/fail APIs now take a payment id. Pending inbound matches are preferred so a | ||
| /// later retry of the same hash does not claim an already-settled record. | ||
| pub(crate) fn bolt11_payment_id_for_hash( |
Collaborator
There was a problem hiding this comment.
I don't think we should do this. Iterating all payments will be prohibitively expensive, esp. after only keeping a cache of them in memory. In LDK Node we decided against keeping a reverse index. I think this PR simply has to update the API to also go with fail_for_id/claim_for_id rather than maintaining the old API shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt payment events to the updated ldk-node API and expose their payment IDs. Continue to handle unknown BOLT 11 payments manually so the receive-for-hash APIs work correctly.
Add payer-proof creation to the gRPC, CLI, and MCP interfaces,