Add network field to GetNodeInfoResponse#198
Open
randomlogin wants to merge 2 commits intolightningdevkit:mainfrom
Open
Add network field to GetNodeInfoResponse#198randomlogin wants to merge 2 commits intolightningdevkit:mainfrom
network field to GetNodeInfoResponse#198randomlogin wants to merge 2 commits intolightningdevkit:mainfrom
Conversation
|
👋 Thanks for assigning @benthecarman as a reviewer! |
2 tasks
benthecarman
requested changes
May 5, 2026
randomlogin
force-pushed
the
add-network-to-node-info
branch
from
928d92a to
20b5d8d
Compare
benthecarman
reviewed
May 5, 2026
Anyitechs
reviewed
May 5, 2026
randomlogin
force-pushed
the
add-network-to-node-info
branch
from
20b5d8d to
63e7184
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the Bitcoin network the node is running on (e.g., "bitcoin", "testnet", "signet", "regtest") via the get-node-info API.
This was merged in lightningdevkit/ldk-node#892
I've bumped the dependency revision of ldk-node to the latest one before breaking changes are introduced (lightningdevkit/ldk-node#850).