Drop entropy creation helper, cleanup remaining warnings #752
+10
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we introduced a `create_test_entropy` helper method in `common.rs` that was only used in one specific test. We here opt to drop this again and also clean up the remaining warnings when run under `--features uniffi`.
|
I've assigned @joostjager as a reviewer! |
joostjager
approved these changes
Jan 13, 2026
Contributor
joostjager
left a comment
joostjager
left a comment
There was a problem hiding this comment.
Should uniffi warnings fail CI?
Collaborator
Author
Hmm, I don't think it's that important. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a tiny follow-up to #750.
Previously we introduced a
create_test_entropyhelper method incommon.rsthat was only used in one specific test. We here opt to drop this again and also clean up the remaining warnings when run under--features uniffi.