Add structured logging context fields to LogRecord #751
+179
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @tnull as a reviewer! |
joostjager
force-pushed
the
structured-logging
branch
from
262db08 to
c74331f
Compare
joostjager
force-pushed
the
structured-logging
branch
from
c74331f to
59d9bb1
Compare
Extend LogRecord with peer_id, channel_id, and payment_hash fields from LDK's Record struct. These structured fields are now available to custom LogWriter implementations and are automatically appended to log messages by the built-in FileWriter and LogFacadeWriter. - Add peer_id, channel_id, payment_hash fields to LogRecord (both uniffi and non-uniffi versions) - Add format_log_context() helper to format fields with truncated hex - Update FileWriter and LogFacadeWriter to append context to messages - Update UDL bindings with new LogRecord fields - Add unit tests for format_log_context and LogFacadeWriter Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
joostjager
force-pushed
the
structured-logging
branch
from
59d9bb1 to
22c37aa
Compare
tnull
reviewed
Jan 12, 2026
Collaborator
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
One comment, otherwise looks good.
While you're at it, mind also making the change to ldk-server as well? See https://github.com/lightningdevkit/ldk-server/blob/f3eaacd327d40fc8ee3fd7f6fbaccb04fa077434/ldk-server/src/util/logger.rs#L86-L129
|
|
||
| let log = format!( | ||
| "{} {:<5} [{}:{}] {}\n", | ||
| "{} {:<5} [{}:{}] {}{}\n", |
Collaborator
There was a problem hiding this comment.
Just appending it plain looks a bit odd for some messages:
Persistence of ChannelMonitorUpdate id 13 completed ch:d6487d p:02d87e
Can we maybe wrap the context in parentheses or brackets?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend LogRecord with peer_id, channel_id, and payment_hash fields from LDK's Record struct. These structured fields are now available to custom LogWriter implementations and are automatically appended to log messages by the built-in FileWriter and LogFacadeWriter.
Closes #712